Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction bugs between animation and sample / feature metadata coloring #195

Closed
fedarko opened this issue Jun 22, 2020 · 2 comments
Closed
Labels

Comments

@fedarko
Copy link
Collaborator

fedarko commented Jun 22, 2020

Steps to reproduce:

  1. Open the animation tab and start some sort of animation
  2. Go to the sample or feature metadata coloring tab (without stopping the animation), and (if not already open) press the checkbox to open up the coloring options.
  3. Change an option (if needed) and press "Update" in the sample or feature metadata coloring tab
  4. The plot will now be updated to use the requested metadata coloring option
  5. ... However, a few seconds later, the animation will continue (since we never stopped it), undoing the metadata coloring methods while still leaving them "checked."

You kind of have to try to break Empress to get this to happen, but it's still confusing -- so we should address this if we can IMO.

@fedarko fedarko added the bug label Jun 22, 2020
@fedarko
Copy link
Collaborator Author

fedarko commented Sep 4, 2020

This will also be a problem with synchronized animations (#319). We can probably get around this by adding a disableColoringUI() function or something that disables all of the "breaking" Empress options while animations are happening, and an enableColoringUI() function that does the reverse (and is called when an animation is finished / restarted / etc.).

@fedarko
Copy link
Collaborator Author

fedarko commented Jul 17, 2021

This was closed by #505. Thanks @kwcantrell! 🎉 🎉 🎉

@fedarko fedarko closed this as completed Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant