Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong comments in commit abb7305e505956421ca0229c6559c34b48dd87f7 #201

Open
RangerNJU opened this issue Oct 18, 2024 · 0 comments
Open

Wrong comments in commit abb7305e505956421ca0229c6559c34b48dd87f7 #201

RangerNJU opened this issue Oct 18, 2024 · 0 comments

Comments

@RangerNJU
Copy link

The commit mentioned in title changed comments in binance/um_futures/account.py

diff --git a/binance/um_futures/account.py b/binance/um_futures/account.py
index bf94291..1c303cb 100644
--- a/binance/um_futures/account.py
+++ b/binance/um_futures/account.py
@@ -9,7 +9,7 @@ def change_position_mode(self, dualSidePosition: str, **kwargs):
     | *Change user's position mode (Hedge Mode or One-way Mode) on EVERY symbol*

     :API endpoint: ``POST /fapi/v1/positionSide/dual``
-    :API doc: https://binance-docs.github.io/apidocs/futures/en/#change-position-mode-trade
+    :API doc: https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/Change-Position-Mode

     :parameter dualSidePosition: string
     :parameter recvWindow: optional int
@@ -29,7 +29,7 @@ def get_position_mode(self, **kwargs):
     | *Get user's position mode (Hedge Mode or One-way Mode) on EVERY symbol*

     :API endpoint: ``GET /fapi/v1/positionSide/dual``
-    :API doc: https://binance-docs.github.io/apidocs/futures/en/#get-current-position-mode-user_data
+    :API doc: https://developers.binance.com/docs/derivatives/usds-margined-futures/account/rest-api/Get-Current-Positi
on-Mode

     :parameter recvWindow: optional int
     |
@@ -47,7 +47,7 @@ def change_multi_asset_mode(self, multiAssetsMargin: str, **kwargs):
     | *Change user's Multi-Assets mode (Multi-Assets Mode or Single-Asset Mode) on Every symbol*

     :API endpoint: ``POST /fapi/v1/multiAssetsMargin``
-    :API doc: https://binance-docs.github.io/apidocs/futures/en/#change-multi-assets-mode-trade
+    :API doc: https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/Change-Multi-Assets-
Mode

     :parameter multiAssetsMargin: string; "true": Multi-Assets Mode; "false": Single-Asset Mode
     :parameter recvWindow: optional int
@@ -67,7 +67,7 @@ def get_multi_asset_mode(self, **kwargs):
     | *Get user's Multi-Assets mode (Multi-Assets Mode or Single-Asset Mode) on Every symbol*

     :API endpoint: ``GET /fapi/v1/multiAssetsMargin``
-    :API doc: https://binance-docs.github.io/apidocs/futures/en/#get-current-multi-assets-mode-user_data
+    :API doc: https://developers.binance.com/docs/derivatives/usds-margined-futures/account/rest-api/Get-Current-Multi-
Assets-Mode

     :parameter recvWindow: optional int
     |
@@ -85,7 +85,7 @@ def new_order(self, symbol: str, side: str, type: str, **kwargs):
     | *Send a new order*

     :API endpoint: ``POST /fapi/v1/order``
-    :API doc: https://binance-docs.github.io/apidocs/futures/en/#new-order-trade
+    :API doc: https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/websocket-api/New-Order

     :parameter symbol: string
     :parameter side: string
@@ -120,7 +120,7 @@ def new_order_test(self, symbol: str, side: str, type: str, **kwargs):
     | *Send a new test order*

     :API endpoint: ``POST /fapi/v1/order/test``
-    :API doc: https://binance-docs.github.io/apidocs/futures/en/#new-order-trade
+    :API doc: https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/websocket-api/New-Order

     :parameter symbol: string
     :parameter side: string
@@ -164,7 +164,7 @@ def modify_order(
     | *Order modify function, currently only LIMIT order modification is supported, modified orders will be reordered in the match queue*

     :API endpoint: ``PUT /fapi/v1/order``
-    :API doc: https://binance-docs.github.io/apidocs/futures/en/#modify-order-trade
+    :API doc: https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/websocket-api/Modify-Order

However these 'websocket-api' lines are wrong, since all this methods are using POST/GET with the RESTful url. The comments should refer to rest-api doc.

Other files may have similar errors, hopefully this can be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant