Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] using unassigned variable in except block after failed assignment in try #121

Open
fabianegli opened this issue May 2, 2022 · 1 comment · Fixed by #162
Open

Comments

@fabianegli
Copy link
Collaborator

fabianegli commented May 2, 2022

Variables with failed assignment in a try block are not available in the corresponding exception.

logger.debug('OLS error searching the following term -- %s iteration %s', req.url, retry_num)

The logging here needs to either compose the url separately or use the variables used to compose the url. Or do both.

@fabianegli fabianegli changed the title [BUG] using (unassigned) variable [assigned in try block but used in except] [BUG] using unassigned variable in except block after failed assignment in try May 2, 2022
@fabianegli
Copy link
Collaborator Author

Wrong reasoning before, but still an issue.

@fabianegli fabianegli reopened this May 2, 2022
@ypriverol ypriverol linked a pull request Feb 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant