Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Empty rows in the middle of the dataset are erroneously accepted #115

Open
fabianegli opened this issue Apr 5, 2022 · 0 comments
Open

Comments

@fabianegli
Copy link
Collaborator

The test for empty rows is probably good enough if these rows are at the beginning or end of the file, but it is not sufficient for the case when there are empty rows in the middle, because that could also be a hint that the file content does not comply with SDRF standards or contains more parts than only the SDRF.

df = df.dropna(axis='index', how='all')
if df.shape[0] < nrows:
logging.warning('There were empty lines.')

@fabianegli fabianegli changed the title [ENH] Empty rows in the middle of the dataset are inadequately accepted [ENH] Empty rows in the middle of the dataset are erroneously accepted Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant