Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Favor pathlib over path string manipulation #107

Open
fabianegli opened this issue Apr 4, 2022 · 1 comment
Open

[MAINT] Favor pathlib over path string manipulation #107

fabianegli opened this issue Apr 4, 2022 · 1 comment
Assignees
Labels

Comments

@fabianegli
Copy link
Collaborator

It would be better to not manually work with path strings but use the modern pathlib instead.

Path = os.path.split(sdrf_file)[0] + '/'

@fabianegli
Copy link
Collaborator Author

Note that Path is orange in the above code snippet? That's because it is the name of the Path object in the Python builtin pathlib library and considered an internal variable. If possible these names should not be used for custom variables if not for a very good reason.

@fabianegli fabianegli added the good first issue Good for newcomers label Apr 5, 2022
@fabianegli fabianegli changed the title [CODE] Favor pathlib over path string manipulation [MAINT] Favor pathlib over path string manipulation Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants