Issue/46 - Fix magic methods not working as intended #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a private data() array, and a public method for classes that extend Base to call to setup the defaults. This is necessary to make sure that all default class variables make their way into the data array so that magic methods can access them like they can any other variable.
This commit is necessary to make sure that all object properties are correctly setup in the private data array.
|
The above upstream WordPress core change was merged into WordPress 5.5! |
|
So should we assume that anything using BerlinDB should be on 5.5 or greater? |
Once this is merged, yes. |
* Change from array to object * Introduce unset_vars() to parlay off of set_vars() * Introduce validate_key() to reduce some code duplication in magic methods * Switch from is_callable() to method_exists() so that it works as intended with __call() * Make sure magic un/set methods operate on the correct variables * Avoid setting object array keys directly, triggering byref debug notices * Some general code & docs improvements to related methods * Add 'join' to query & request clauses
alexstandiford
requested changes
Sep 8, 2021
👍
It doesn't yet, but it will when #46 is resolved, which is in the Ongoing milestone for pretty much this reason. Based on the WordPress functions that Berlin uses, its minimum is probably 3.3 thanks to it calling That's a pretty big jump from 3.3 to 5.5, so I'm not super eager to merge this. 😬 |
|
Yep, totally understandable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes quite a bit about how classes store their properties.
$this->dataarrayBasehave internal logic for allowingget_functions to work as intended$this->fooends up in$this->data['foo']so that it can always be magically overridden, or notAll of this is required to make overrides work as intended. But then, WordPress functions that use
WP_List_Utilwill then stop working, because they usearray_key_exists()which will bypass PHP magic methods completely.That means this PR either requires:
Fixes #46.
Related to: https://core.trac.wordpress.org/ticket/50095