Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade fontawesome #305

Open
Zhangby1998 opened this issue Jun 11, 2023 · 3 comments
Open

upgrade fontawesome #305

Zhangby1998 opened this issue Jun 11, 2023 · 3 comments
Labels
Milestone

Comments

@Zhangby1998
Copy link

Font-Awesome (FortAwesome/Font-Awesome) after v5 (circa 2018) uses "fontawesome.min.css" as filename, not "font-awesome", as written in _layout.html, L18, which cause permission icon unable to show up properly.
L6J6Y4PECRMZU}XRQ816A

@ThomasWaldmann
Copy link
Contributor

ThomasWaldmann commented Jun 11, 2023

Thanks for the hint. Seems like this worked until Dec 2022, as there was only fontawesome v4 as xstatic package, which then got updated to v6.

So we can either limit to the older fontawesome (which is likely to fix all issues, but a bit backwards and not future-proof):
https://github.com/bepasty/bepasty-server/blob/master/setup.cfg#L42

Maybe this approach would be good for a minor patch release.

Or we can upgrade bepasty to v5 and then to v6, which needs a review of fontawesome change log and upgrade notes and then a global review of our usage according to that - maybe more changes than the one noted in top post are needed?

This approach is what we need for future releases.

@ThomasWaldmann ThomasWaldmann added this to the 1.1.1 milestone Jun 11, 2023
ThomasWaldmann added a commit to ThomasWaldmann/bepasty-server that referenced this issue Aug 28, 2023
ThomasWaldmann added a commit that referenced this issue Aug 28, 2023
@ThomasWaldmann
Copy link
Contributor

ThomasWaldmann commented Aug 28, 2023

Release 1.2.0 will include the workaround by requiring the old xstatic-font-awesome pypi package.

@ThomasWaldmann ThomasWaldmann modified the milestones: 1.2.0, 2.0.0 Aug 28, 2023
@ThomasWaldmann
Copy link
Contributor

TODO: Upgrade bepasty to use xstatic-font-awesome 5.x (and later to 6.x), which needs a review of fontawesome change log and upgrade notes and then a global review of our usage according to that.

@ThomasWaldmann ThomasWaldmann changed the title Incorrect css name for Font Awesome upgrade fontawesome Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants