-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade fontawesome #305
Comments
Thanks for the hint. Seems like this worked until Dec 2022, as there was only fontawesome v4 as xstatic package, which then got updated to v6. So we can either limit to the older fontawesome (which is likely to fix all issues, but a bit backwards and not future-proof): Maybe this approach would be good for a minor patch release. Or we can upgrade bepasty to v5 and then to v6, which needs a review of fontawesome change log and upgrade notes and then a global review of our usage according to that - maybe more changes than the one noted in top post are needed? This approach is what we need for future releases. |
use xstatic-fontawesome < 5, see #305
Release 1.2.0 will include the workaround by requiring the old xstatic-font-awesome pypi package. |
TODO: Upgrade bepasty to use xstatic-font-awesome 5.x (and later to 6.x), which needs a review of fontawesome change log and upgrade notes and then a global review of our usage according to that. |
Font-Awesome (FortAwesome/Font-Awesome) after v5 (circa 2018) uses "fontawesome.min.css" as filename, not "font-awesome", as written in _layout.html, L18, which cause permission icon unable to show up properly.
The text was updated successfully, but these errors were encountered: