Following CONTRIBUTING.md: npm run test fails, npm run lint script is missing

[mtrefzer]

According to CONTRIBUTING.md after cloning the repo and running npm ci npm run test fails and npm run lint doesn't work because there is not lint in the scripts section.

To Reproduce
Steps to reproduce the behavior:

1. git clone https://github.com/bennymeg/nx-electron.git
2. cd nx-electron && npm link
3. npm ci
4. npm run test
5. initially throws various errors
6. npm run lint
7. there is no lint in the scripts section

Expected behavior
Without any changes all tests should run without any errors.
Either add lint to the scripts section or remove the part about linting the forked project from CONTRIBUTING.md file.

Desktop (please complete the following information):

• OS: Ubuntu 22.04.1
• Nx Electron Version [latest]
• node: v16.13.1
• npm: v8.1.2

[dhrn]

+1

[ErickRodrCodes]

test fails since Nx 15.4 changes the cli architecture.

[bennymeg]

The tests need a lot of reworks, and some are broken for quite a long time (unfortunately)
I'll add a lint script once I will allocate some time to work on v14/15

[ErickRodrCodes]

Count me in @bennymeg , I have fix partially some of the test scripts.

• Please use join.path for tests related to paths. static paths break tests on windows, and I believe you are in a mac
• I need to get more familiar with nx schematics and migration, so I can be able to provide a decent PR.
• I am willing to put my own time to help with this project, so please let me know.

[ErickRodrCodes]

Ok, for 15, I'm going to probably write a FULL REWRITE. yes. and this is why

The constant issues the current plugin has in terms of testing make it inviable to use it as it is. so I will create a separate branch JUST FOR 15, and work from there.

There might be no point in doing the migration from 14 with all the breaking changes it is having. Better to have clear schematics from start.

[bennymeg]

please wait a bit until I will release v14 (by the end of this week) and branch from there.

[ErickRodrCodes]

ok! then I will wait 😂, migration from there should be easy.

I would suggest to take a look into the vite plugin for electron. probably a good option for rewrite: https://github.com/alex8088/electron-vite