Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Geography __eq__ object equality? #48

Open
jorisvandenbossche opened this issue Oct 3, 2024 · 2 comments · May be fixed by #61
Open

Add Geography __eq__ object equality? #48

jorisvandenbossche opened this issue Oct 3, 2024 · 2 comments · May be fixed by #61

Comments

@jorisvandenbossche
Copy link
Collaborator

Currently two different but equal objects are not "equal":

In [14]: import spherely

In [15]: p1 = spherely.Point(2, 2)

In [16]: p2 = spherely.Point(2, 2)

In [17]: p1 == p2
Out[17]: False
@JoelJaeschke
Copy link

If this is still a relevant issue, I would like to give this a shot!

@jorisvandenbossche
Copy link
Collaborator Author

This is certainly still relevant!

I assume that we would want to do the same as the equals predicate (i.e. using s2geography::s2_intersects)

@JoelJaeschke JoelJaeschke linked a pull request Oct 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: implement __eq__ on Geography class JoelJaeschke/spherely
2 participants
@jorisvandenbossche @JoelJaeschke