Skip to content
This repository has been archived by the owner on Aug 5, 2023. It is now read-only.

Use SM profile display name as the player card name #28

Open
MrTwinkles47 opened this issue Apr 2, 2021 · 3 comments
Open

Use SM profile display name as the player card name #28

MrTwinkles47 opened this issue Apr 2, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@MrTwinkles47
Copy link

If current player has loaded a profile, use the profile's display name as the player card name. Otherwise, continue to use the random Player nnn player name.

Lua to grab the profile name: PROFILEMAN:GetProfile(player):GetDisplayName()

@benank
Copy link
Owner

benank commented Apr 3, 2021

I considered this for a while and didn't implement it because of conflict handling - if a player has a display name set in their profile and they decide to change their name on everyone.dance to something else, what should be displayed next time they open it? The saved one, or the profile name? Maybe if there's a profile name then it always takes precedence unless the player edits their name in the game room?

@benank benank added the enhancement New feature or request label Apr 3, 2021
@MrTwinkles47
Copy link
Author

Maybe if there's a profile name then it always takes precedence unless the player edits their name in the game room?

This is how I was picturing it. Use the SM profile name as default, but any edit to the player name in everyone.dance will take priority.

@benank
Copy link
Owner

benank commented Apr 3, 2021

Gotcha! I'll bundle this in with some other updates probably later today!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants