From e3af4a0b565f13eba668f227173c4258831fde68 Mon Sep 17 00:00:00 2001
From: dante di domenico <dante@didoda.com>
Date: Tue, 19 Mar 2024 09:56:28 +0100
Subject: [PATCH 1/5] feat: optimize tree

---
 config/routes.php                             |  15 ++
 locales/default.pot                           |  23 +-
 locales/en_US/default.po                      |  23 +-
 locales/it_IT/default.po                      |  23 +-
 .../js/app/components/tree-view/tree-view.vue | 114 +++++---
 src/Controller/TreeController.php             | 216 ++++++++++++++-
 .../Controller/TreeControllerTest.php         | 255 ++++++++++++++++--
 7 files changed, 592 insertions(+), 77 deletions(-)

diff --git a/config/routes.php b/config/routes.php
index 125622b14..9116b6b07 100644
--- a/config/routes.php
+++ b/config/routes.php
@@ -101,6 +101,21 @@
         ['controller' => 'Tree', 'action' => 'get'],
         ['_name' => 'tree:get']
     );
+    $routes->connect(
+        '/tree/node/{id}',
+        ['controller' => 'Tree', 'action' => 'node'],
+        ['_name' => 'tree:node', 'pass' => ['id']]
+    );
+    $routes->connect(
+        '/tree/parent/{id}',
+        ['controller' => 'Tree', 'action' => 'parent'],
+        ['_name' => 'tree:parent', 'pass' => ['id']]
+    );
+    $routes->connect(
+        '/tree/parents/{type}/{id}',
+        ['controller' => 'Tree', 'action' => 'parents'],
+        ['_name' => 'tree:parents', 'pass' => ['type', 'id']]
+    );
 
     // Admin.
     $routes->prefix('admin', ['_namePrefix' => 'admin:'], function (RouteBuilder $routes) {
diff --git a/locales/default.pot b/locales/default.pot
index b491aad3f..4bd214b28 100644
--- a/locales/default.pot
+++ b/locales/default.pot
@@ -1,7 +1,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: BEdita 4 \n"
-"POT-Creation-Date: 2024-02-26 14:54:49 \n"
+"POT-Creation-Date: 2024-03-19 07:51:20 \n"
 "MIME-Version: 1.0 \n"
 "Content-Transfer-Encoding: 8bit \n"
 "Language-Team: BEdita I18N & I10N Team \n"
@@ -1221,9 +1221,30 @@ msgstr ""
 msgid "Canonical"
 msgstr ""
 
+msgid "Loading branches for position"
+msgstr ""
+
+msgid "Loading children for folder"
+msgstr ""
+
+msgid "Loading folder"
+msgstr ""
+
+msgid "Loading parent for folder"
+msgstr ""
+
+msgid "Loading positions for object"
+msgstr ""
+
+msgid "Loading root folders"
+msgstr ""
+
 msgid "Menu"
 msgstr ""
 
+msgid "page"
+msgstr ""
+
 msgid "View"
 msgstr ""
 
diff --git a/locales/en_US/default.po b/locales/en_US/default.po
index c03c7d0df..b54b699e1 100644
--- a/locales/en_US/default.po
+++ b/locales/en_US/default.po
@@ -1,7 +1,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: BEdita Manager \n"
-"POT-Creation-Date: 2024-02-26 14:54:49 \n"
+"POT-Creation-Date: 2024-03-19 07:51:20 \n"
 "PO-Revision-Date:  \n"
 "Last-Translator:  \n"
 "Language-Team: BEdita I18N & I10N Team \n"
@@ -1224,9 +1224,30 @@ msgstr ""
 msgid "Canonical"
 msgstr ""
 
+msgid "Loading branches for position"
+msgstr ""
+
+msgid "Loading children for folder"
+msgstr ""
+
+msgid "Loading folder"
+msgstr ""
+
+msgid "Loading parent for folder"
+msgstr ""
+
+msgid "Loading positions for object"
+msgstr ""
+
+msgid "Loading root folders"
+msgstr ""
+
 msgid "Menu"
 msgstr ""
 
+msgid "page"
+msgstr ""
+
 msgid "View"
 msgstr ""
 
diff --git a/locales/it_IT/default.po b/locales/it_IT/default.po
index e7aa96935..a8e3b02fb 100644
--- a/locales/it_IT/default.po
+++ b/locales/it_IT/default.po
@@ -1,7 +1,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: BEdita Manager \n"
-"POT-Creation-Date: 2024-02-26 14:54:49 \n"
+"POT-Creation-Date: 2024-03-19 07:51:20 \n"
 "PO-Revision-Date:  \n"
 "Last-Translator:  \n"
 "Language-Team: BEdita I18N & I10N Team \n"
@@ -1236,9 +1236,30 @@ msgstr "Utente"
 msgid "Canonical"
 msgstr "Canonica"
 
+msgid "Loading branches for position"
+msgstr "Caricamento rami per posizione"
+
+msgid "Loading children for folder"
+msgstr "Caricamento contenuti per cartella"
+
+msgid "Loading folder"
+msgstr "Caricamento cartella"
+
+msgid "Loading parent for folder"
+msgstr "Caricamento genitore per cartella"
+
+msgid "Loading positions for object"
+msgstr "Caricamento posizioni per oggetto"
+
+msgid "Loading root folders"
+msgstr "Caricamento cartelle principali"
+
 msgid "Menu"
 msgstr "Menù"
 
+msgid "page"
+msgstr "pagina"
+
 msgid "View"
 msgstr "Vedi"
 
diff --git a/resources/js/app/components/tree-view/tree-view.vue b/resources/js/app/components/tree-view/tree-view.vue
index 87517de31..2c02bf7d5 100644
--- a/resources/js/app/components/tree-view/tree-view.vue
+++ b/resources/js/app/components/tree-view/tree-view.vue
@@ -1,7 +1,10 @@
 <template>
     <div class="tree-view-node" :class="{'is-root': isRoot}" v-show="showNode">
         <input v-if="originalParents.length > 0" type="hidden" name="_originalParents" :value="originalParents" />
-        <div v-if="isLoading && !parent" class="is-loading-spinner"></div>
+        <div v-if="isLoading && !parent" class="is-loading-spinner">
+            <div v-if="loadingMainMessage">{{ loadingMainMessage }}</div>
+            <div v-if="loadingSubMessage">{{ loadingSubMessage }}</div>
+        </div>
         <div v-if="parent" class="node-element py-05" :data-status="node.attributes.status">
             <label class="node-label" :class="{'icon-folder': !relationName, 'has-text-gray-550 disabled': object && node.id == object.id}" v-on="{ click: relationName ? () => {} : toggle }">
                 <input v-if="relationName"
@@ -20,10 +23,14 @@
                 <app-icon icon="carbon:unlocked" v-if="!isLocked"></app-icon>
                 <app-icon icon="carbon:tree-view" v-if="node.meta.perms.inherited"></app-icon>
             </span>
-            <button v-if="(!node.children || node.children.length !== 0) && (!object || node.id != object.id) && showNode"
-                :class="{'is-loading-spinner': isLoading, 'icon-down-open': !isLoading && isOpen, 'icon-right-open': !isLoading && !isOpen}"
-                @click="toggle">
-            </button>
+            <template v-if="(!node.children || node.children.length !== 0) && (!object || node.id != object.id) && showNode">
+                <button
+                    :class="{'is-loading-spinner': isLoading, 'icon-down-open': !isLoading && isOpen, 'icon-right-open': !isLoading && !isOpen}"
+                    @click="toggle">
+                </button>
+                <div v-if="isLoading && loadingMainMessage">{{ loadingMainMessage }}</div>
+                <div v-if="isLoading && loadingSubMessage">{{ loadingSubMessage }}</div>
+            </template>
             <a :href="url" v-if="hasPermissionRoles && isLocked">{{ msgView }}</a>
             <a :href="url" v-else>{{ msgEdit }}</a>
             <div class="tree-params">
@@ -107,13 +114,17 @@ const API_OPTIONS = {
 };
 
 export default {
-    name: 'tree-view',
+    name: 'TreeView',
 
     props: {
         store: {
             type: Object,
             default: () => ({}),
         },
+        parentsStore: {
+            type: Object,
+            default: () => ({}),
+        },
         parent: {
             type: Object,
             default: null,
@@ -162,10 +173,21 @@ export default {
             canonical: false,
             isOpen: false,
             isLoading: false,
+            loadingCounter: 0,
+            loadingMainMessage: '',
+            loadingSubMessage: '',
+            totalCounter: 0,
             menu: false,
             msgCanonical: t`Canonical`,
             msgEdit: t`Edit`,
+            msgLoadingBranchesForPosition: t`Loading branches for position`,
+            msgLoadingChildrenForFolder: t`Loading children for folder`,
+            msgLoadingFolder: t`Loading folder`,
+            msgLoadingParentForFolder: t`Loading parent for folder`,
+            msgLoadingPositionsForObject: t`Loading positions for object`,
+            msgLoadingRoots: t`Loading root folders`,
             msgMenu: t`Menu`,
+            msgPage: t`page`,
             msgView: t`View`,
             originalParents: [],
             showForbidden: true,
@@ -308,7 +330,7 @@ export default {
          * @return {Promise}
          */
         async loadRoots() {
-            if (this.object && this.object.id) {
+            if (this.object && this.object.id && this.object.type) {
                 await this.preload(this.object);
             }
 
@@ -316,6 +338,7 @@ export default {
             let roots = [];
             let done = false;
             do {
+                this.loadingMainMessage = this.msgLoadingRoots;
                 let response = await fetch(`${API_URL}tree?filter[roots]&page=${page}&page_size=100`, API_OPTIONS);
                 let json = await response.json();
                 json = json?.tree || {};
@@ -344,15 +367,10 @@ export default {
          * @return {Promise}
          */
         async preload({ id, type }) {
-            if (!type) {
-                let response = await fetch(`${API_URL}api/objects/${id}`, API_OPTIONS);
-                let json = await response.json();
-                type = json.data.type;
-            }
-
             if (type === 'folders') {
-                let response = await fetch(`${API_URL}api/folders/${id}`, API_OPTIONS)
-                let { data: folder } = await response.json();
+                this.loadingMainMessage = this.msgLoadingFolder + ` ${id}`;
+                const resp = await fetch(`${API_URL}tree/node/${id}`, API_OPTIONS);
+                let { data: folder } = await resp.json();
                 this.store[folder.id] = folder;
                 let parent = await this.loadParent(folder);
                 if (!parent) {
@@ -363,16 +381,21 @@ export default {
                 return [await this.loadFolderParentRecursive(parent)];
             }
 
-            let response = await fetch(`${API_URL}api/${type}/${id}?include=parents`);
+            this.loadingMainMessage = this.msgLoadingPositionsForObject + ` ${id}`;
+            const response = await fetch(`${API_URL}tree/parents/${type}/${id}`);
             let json = await response.json();
-            let included = json.included || [];
-            return await Promise.all(
-                included.map(async (folder) => {
-                    this.store[folder.id] = folder;
-                    this.parents.push(folder);
-                    return this.loadFolderParentRecursive(folder);
-                })
-            );
+            let included = json.parents || [];
+            this.totalCounter = included.length;
+            this.loadingCounter = 0;
+            for (let item of included) {
+                this.store[item.id] = item;
+                this.parents.push(item);
+                item = await this.loadFolderParentRecursive(item);
+                this.loadingCounter++;
+                this.loadingMainMessage = this.msgLoadingBranchesForPosition + `: ${this.loadingCounter} / ${this.totalCounter}`;
+            }
+
+            return Promise.all(included);
         },
 
         /**
@@ -382,12 +405,21 @@ export default {
          * @return {Promise}
          */
         async loadParent(folder) {
-            let response = await fetch(`${API_URL}api/folders/${folder.id}/parent`, API_OPTIONS);
+            if (this.parentsStore[folder.id]) {
+                return this.parentsStore[folder.id];
+            }
+            const id = folder.id;
+            this.loadingSubMessage = this.msgLoadingParentForFolder + ` ${id}`;
+            const response = await fetch(`${API_URL}tree/parent/${id}`, API_OPTIONS);
             let json = await response.json();
-            let { data: object } = json;
-            if (!object) {
+            let object = json?.parent;
+            if (!object?.id) {
+                this.parentsStore[id] = null;
+
                 return null;
             }
+            this.parentsStore[id] = object;
+
             return this.store[object.id] || (this.store[object.id] = object);
         },
 
@@ -402,7 +434,9 @@ export default {
             let children = [];
             let done = false;
             do {
-                let childrenRes = await fetch(`${API_URL}tree?filter[parent]=${folder.id}&page=${page}&page_size=100`, API_OPTIONS);
+                const id = folder.id;
+                this.loadingSubMessage = this.msgLoadingChildrenForFolder + ` ${id} (` + this.msgPage + ` ${page})`;
+                let childrenRes = await fetch(`${API_URL}tree?filter[parent]=${id}&page=${page}&page_size=100`, API_OPTIONS);
                 let childrenJson = await childrenRes.json();
                 childrenJson = childrenJson?.tree || {};
                 children.push(
@@ -425,15 +459,19 @@ export default {
          * @return {Promise}
          */
         async loadFolderParentRecursive(folder) {
-            let parent = await this.loadParent(folder);
-            if (parent) {
-                if (!parent.children) {
-                    await this.loadChildren(parent);
-                }
-                return await this.loadFolderParentRecursive(parent);
+            let parent;
+            if (Object.keys(this.parentsStore).indexOf(folder.id) >= 0) {
+                parent = this.parentsStore[folder.id];
+            } else {
+                parent = await this.loadParent(folder);
             }
-
-            return folder;
+            if (!parent) {
+                return folder;
+            }
+            if (!this.store[parent.id].children) {
+                await this.loadChildren(parent);
+            }
+            return await this.loadFolderParentRecursive(parent);
         },
 
         /**
@@ -457,7 +495,9 @@ export default {
             let done = false;
             this.isLoading = true;
             do {
-                let response = await fetch(`${API_URL}tree?filter[parent]=${this.node.id}&page=${page}&page_size=100`, API_OPTIONS);
+                const id = this.node.id;
+                this.loadingSubMessage = this.msgLoadingChildrenForFolder + ` ${id} (` + this.msgPage + ` ${page})`;
+                let response = await fetch(`${API_URL}tree?filter[parent]=${id}&page=${page}&page_size=100`, API_OPTIONS);
                 let json = await response.json();
                 json = json?.tree || {};
                 children.push(...json.data);
diff --git a/src/Controller/TreeController.php b/src/Controller/TreeController.php
index 8f943a072..bcc2150ec 100644
--- a/src/Controller/TreeController.php
+++ b/src/Controller/TreeController.php
@@ -28,6 +28,7 @@ class TreeController extends AppController
     /**
      * Get tree data.
      * Use this for /tree?filter[roots]&... and /tree?filter[parent]=x&...
+     * Use cache to store data.
      *
      * @return void
      */
@@ -36,11 +37,60 @@ public function get(): void
         $this->getRequest()->allowMethod(['get']);
         $this->viewBuilder()->setClassName('Json');
         $query = $this->getRequest()->getQueryParams();
-        $tree = $this->data($query);
+        $tree = $this->treeData($query);
         $this->set('tree', $tree);
         $this->setSerialize(['tree']);
     }
 
+    /**
+     * Get node by ID.
+     * Use cache to store data.
+     *
+     * @param string $id The ID.
+     * @return void
+     */
+    public function node(string $id): void
+    {
+        $this->getRequest()->allowMethod(['get']);
+        $this->viewBuilder()->setClassName('Json');
+        $node = $this->fetchNodeData($id);
+        $this->set('node', $node);
+        $this->setSerialize(['node']);
+    }
+
+    /**
+     * Get parent by ID.
+     * Use cache to store data.
+     *
+     * @param string $id The ID.
+     * @return void
+     */
+    public function parent(string $id): void
+    {
+        $this->getRequest()->allowMethod(['get']);
+        $this->viewBuilder()->setClassName('Json');
+        $parent = $this->fetchParentData($id);
+        $this->set('parent', $parent);
+        $this->setSerialize(['parent']);
+    }
+
+    /**
+     * Get parents by ID and type.
+     * Use cache to store data.
+     *
+     * @param string $type The type.
+     * @param string $id The ID.
+     * @return void
+     */
+    public function parents(string $type, string $id): void
+    {
+        $this->getRequest()->allowMethod(['get']);
+        $this->viewBuilder()->setClassName('Json');
+        $parents = $this->fetchParentsData($id, $type);
+        $this->set('parents', $parents);
+        $this->setSerialize(['parents']);
+    }
+
     /**
      * Get tree data by query params.
      * Use cache to store data.
@@ -48,7 +98,7 @@ public function get(): void
      * @param array $query Query params.
      * @return array
      */
-    public function data(array $query): array
+    public function treeData(array $query): array
     {
         $filter = Hash::get($query, 'filter', []);
         $subkey = !empty($filter['parent']) ? sprintf('parent-%s', $filter['parent']) : 'roots';
@@ -65,7 +115,107 @@ function ($key) {
             $data = Cache::remember(
                 $key,
                 function () use ($query) {
-                    return $this->fetchData($query);
+                    return $this->fetchTreeData($query);
+                },
+                TreeCacheEventHandler::CACHE_CONFIG
+            );
+        } catch (BEditaClientException $e) {
+            // Something bad happened
+            $this->log($e->getMessage(), LogLevel::ERROR);
+
+            return [];
+        }
+
+        return $data;
+    }
+
+    /**
+     * Get node from ID.
+     * It uses cache to store data.
+     *
+     * @param string $id The ID.
+     * @return array|null
+     */
+    public function fetchNodeData(string $id): ?array
+    {
+        $key = CacheTools::cacheKey(sprintf('tree-node-%s', $id));
+        $data = [];
+        try {
+            $data = Cache::remember(
+                $key,
+                function () use ($id) {
+                    $response = ApiClientProvider::getApiClient()->get(sprintf('/folders/%s', $id));
+                    $data = (array)Hash::get($response, 'data');
+
+                    return $this->minimalData($data);
+                },
+                TreeCacheEventHandler::CACHE_CONFIG
+            );
+        } catch (BEditaClientException $e) {
+            // Something bad happened
+            $this->log($e->getMessage(), LogLevel::ERROR);
+
+            return [];
+        }
+
+        return $data;
+    }
+
+    /**
+     * Get parent from ID.
+     * It uses cache to store data.
+     *
+     * @param string $id The ID.
+     * @return array|null
+     */
+    public function fetchParentData(string $id): ?array
+    {
+        $key = CacheTools::cacheKey(sprintf('tree-parent-%s', $id));
+        $data = [];
+        try {
+            $data = Cache::remember(
+                $key,
+                function () use ($id) {
+                    $response = ApiClientProvider::getApiClient()->get(sprintf('/folders/%s/parent', $id));
+                    $data = (array)Hash::get($response, 'data');
+
+                    return $this->minimalDataWithMeta($data);
+                },
+                TreeCacheEventHandler::CACHE_CONFIG
+            );
+        } catch (BEditaClientException $e) {
+            // Something bad happened
+            $this->log($e->getMessage(), LogLevel::ERROR);
+
+            return [];
+        }
+
+        return $data;
+    }
+
+    /**
+     * Get parent from ID.
+     * It uses cache to store data.
+     *
+     * @param string $id The ID.
+     * @param string $type The type.
+     * @return array
+     */
+    public function fetchParentsData(string $id, string $type): array
+    {
+        $key = CacheTools::cacheKey(sprintf('tree-parents-%s-%s', $id, $type));
+        $data = [];
+        try {
+            $data = Cache::remember(
+                $key,
+                function () use ($id, $type) {
+                    $response = ApiClientProvider::getApiClient()->get(sprintf('/%s/%s?include=parents', $type, $id));
+                    $included = (array)Hash::get($response, 'included');
+                    foreach ($included as &$item) {
+                        $item = $this->minimalData((array)$item);
+                    }
+
+                    return $included;
                 },
                 TreeCacheEventHandler::CACHE_CONFIG
             );
@@ -87,20 +237,68 @@ function () use ($query) {
      * @param array $query Query params.
      * @return array
      */
-    protected function fetchData(array $query): array
+    protected function fetchTreeData(array $query): array
     {
         $fields = 'id,status,title';
         $response = ApiClientProvider::getApiClient()->get('/folders', compact('fields') + $query);
         $data = (array)Hash::get($response, 'data');
         $meta = (array)Hash::get($response, 'meta');
         foreach ($data as &$item) {
-            $item = [
-                'id' => $item['id'],
-                'type' => 'folders',
-                'attributes' => $item['attributes'],
-            ];
+            $item = $this->minimalData((array)$item);
         }
 
         return compact('data', 'meta');
     }
+
+    /**
+     * Get minimal data for object.
+     *
+     * @param array $fullData Full data.
+     * @return array
+     */
+    protected function minimalData(array $fullData): array
+    {
+        if (empty($fullData)) {
+            return [];
+        }
+
+        return [
+            'id' => (string)Hash::get($fullData, 'id'),
+            'type' => (string)Hash::get($fullData, 'type'),
+            'attributes' => [
+                'title' => (string)Hash::get($fullData, 'attributes.title'),
+                'status' => (string)Hash::get($fullData, 'attributes.status'),
+            ],
+        ];
+    }
+
+    /**
+     * Get minimal data for object with meta.
+     *
+     * @param array $fullData Full data.
+     * @return array|null
+     */
+    protected function minimalDataWithMeta(array $fullData): ?array
+    {
+        if (empty($fullData)) {
+            return null;
+        }
+
+        return [
+            'id' => (string)Hash::get($fullData, 'id'),
+            'type' => (string)Hash::get($fullData, 'type'),
+            'attributes' => [
+                'title' => (string)Hash::get($fullData, 'attributes.title'),
+                'status' => (string)Hash::get($fullData, 'attributes.status'),
+            ],
+            'meta' => [
+                'path' => (string)Hash::get($fullData, 'meta.path'),
+                'relation' => [
+                    'canonical' => (string)Hash::get($fullData, 'meta.relation.canonical'),
+                    'depth_level' => (string)Hash::get($fullData, 'meta.relation.depth_level'),
+                    'menu' => (string)Hash::get($fullData, 'meta.relation.menu'),
+                ],
+            ],
+        ];
+    }
 }
diff --git a/tests/TestCase/Controller/TreeControllerTest.php b/tests/TestCase/Controller/TreeControllerTest.php
index 54aa44005..c6801e060 100644
--- a/tests/TestCase/Controller/TreeControllerTest.php
+++ b/tests/TestCase/Controller/TreeControllerTest.php
@@ -16,9 +16,8 @@
 
 use App\Controller\TreeController;
 use BEdita\SDK\BEditaClientException;
-use BEdita\WebTools\ApiClientProvider;
 use Cake\Http\ServerRequest;
-use Cake\TestSuite\TestCase;
+use Cake\Utility\Hash;
 
 /**
  * {@see \App\Controller\TreeController} Test Case
@@ -26,7 +25,7 @@
  * @coversDefaultClass \App\Controller\TreeController
  * @uses \App\Controller\TreeController
  */
-class TreeControllerTest extends TestCase
+class TreeControllerTest extends BaseControllerTest
 {
     /**
      * @inheritDoc
@@ -37,34 +36,13 @@ public function setUp(): void
         $this->loadRoutes();
     }
 
-    /**
-     * Test api client
-     *
-     * @var \BEdita\SDK\BEditaClient
-     */
-    public $client;
-
-    /**
-     * Setup api client and auth
-     *
-     * @return void
-     */
-    private function setupApi(): void
-    {
-        $this->client = ApiClientProvider::getApiClient();
-        $adminUser = getenv('BEDITA_ADMIN_USR');
-        $adminPassword = getenv('BEDITA_ADMIN_PWD');
-        $response = $this->client->authenticate($adminUser, $adminPassword);
-        $this->client->setupTokens($response['meta']);
-    }
-
     /**
      * Test `get` method
      *
      * @return void
      * @covers ::get()
-     * @covers ::data()
-     * @covers ::fetchData()
+     * @covers ::treeData()
+     * @covers ::fetchTreeData()
      */
     public function testGet(): void
     {
@@ -88,11 +66,11 @@ public function testGet(): void
     }
 
     /**
-     * Test `data` method on exception
+     * Test `treeData` method on exception
      *
      * @return void
      * @covers ::get()
-     * @covers ::data()
+     * @covers ::treeData()
      */
     public function testDataException(): void
     {
@@ -115,4 +93,225 @@ public function fetchData(array $query): array
         $actual = $tree->viewBuilder()->getVar('tree');
         static::assertEmpty($actual);
     }
+
+    /**
+     * Test `node` method
+     *
+     * @return void
+     * @covers ::node()
+     * @covers ::fetchNodeData()
+     * @covers ::minimalData()
+     */
+    public function testNode(): void
+    {
+        $this->setupApi();
+        $folder = $this->createTestFolder();
+        $id = (string)Hash::get($folder, 'id');
+        $config = [
+            'environment' => [
+                'REQUEST_METHOD' => 'GET',
+            ],
+            'get' => [],
+            'params' => compact('id'),
+        ];
+        $request = new ServerRequest($config);
+        $tree = new TreeController($request);
+        $tree->node($id);
+        $actual = $tree->viewBuilder()->getVar('node');
+        static::assertNotEmpty($actual);
+        static::assertEquals($id, $actual['id']);
+        static::assertEquals('folders', $actual['type']);
+        static::assertEquals('controller test folder', $actual['attributes']['title']);
+        $expectedAttributes = ['status', 'title'];
+        $actualAttributes = array_keys($actual['attributes']);
+        sort($actualAttributes);
+        static::assertEquals($expectedAttributes, $actualAttributes);
+    }
+
+    /**
+     * Test `node` method
+     *
+     * @return void
+     * @covers ::node()
+     * @covers ::fetchNodeData()
+     */
+    public function testNodeException(): void
+    {
+        $this->setupApi();
+        $id = '99999999';
+        $config = [
+            'environment' => [
+                'REQUEST_METHOD' => 'GET',
+            ],
+            'get' => [],
+            'params' => compact('id'),
+        ];
+        $request = new ServerRequest($config);
+        $tree = new TreeController($request);
+        $tree->node($id);
+        $actual = $tree->viewBuilder()->getVar('node');
+        static::assertEmpty($actual);
+    }
+
+    /**
+     * Test `parent` method
+     *
+     * @return void
+     * @covers ::parent()
+     * @covers ::fetchParentData()
+     * @covers ::minimalDataWithMeta()
+     */
+    public function testParent(): void
+    {
+        $this->setupApi();
+        $parent = $this->createTestFolder();
+        $response = $this->client->save('folders', [
+            'title' => 'controller test folder child',
+            'parent_id' => (string)Hash::get($parent, 'id'),
+        ]);
+        $child = $response['data'];
+        $id = (string)Hash::get($child, 'id');
+        $config = [
+            'environment' => [
+                'REQUEST_METHOD' => 'GET',
+            ],
+            'get' => [],
+            'params' => compact('id'),
+        ];
+        $request = new ServerRequest($config);
+        $tree = new TreeController($request);
+        $tree->parent($id);
+        $actual = $tree->viewBuilder()->getVar('parent');
+        static::assertNotEmpty($actual);
+        static::assertEquals('folders', $actual['type']);
+        static::assertEquals($parent['id'], $actual['id']);
+    }
+
+    /**
+     * Test `parent` method
+     *
+     * @return void
+     * @covers ::parent()
+     * @covers ::fetchParentData()
+     * @covers ::minimalDataWithMeta()
+     */
+    public function testParentNull(): void
+    {
+        $this->setupApi();
+        $child = $this->createTestFolder();
+        $id = (string)Hash::get($child, 'id');
+        $config = [
+            'environment' => [
+                'REQUEST_METHOD' => 'GET',
+            ],
+            'get' => [],
+            'params' => compact('id'),
+        ];
+        $request = new ServerRequest($config);
+        $tree = new TreeController($request);
+        $tree->parent($id);
+        $actual = $tree->viewBuilder()->getVar('parent');
+        static::assertNull($actual);
+    }
+
+    /**
+     * Test `parent` method
+     *
+     * @return void
+     * @covers ::parent()
+     * @covers ::fetchParentData()
+     */
+    public function testParentException(): void
+    {
+        $this->setupApi();
+        $id = '99999999';
+        $config = [
+            'environment' => [
+                'REQUEST_METHOD' => 'GET',
+            ],
+            'get' => [],
+            'params' => compact('id'),
+        ];
+        $request = new ServerRequest($config);
+        $tree = new TreeController($request);
+        $tree->parent($id);
+        $actual = $tree->viewBuilder()->getVar('parent');
+        static::assertEmpty($actual);
+    }
+
+    /**
+     * Test `parents` method
+     *
+     * @return void
+     * @covers ::parents()
+     * @covers ::fetchParentsData()
+     * @covers ::minimalData()
+     */
+    public function testParents(): void
+    {
+        $this->setupApi();
+        $parent = $this->createTestFolder();
+        $docs = [
+            'child document 1',
+            'child document 2',
+            'child document 3',
+        ];
+        $ids = [];
+        $type = 'documents';
+        foreach ($docs as $title) {
+            $response = $this->client->save($type, [
+                'title' => $title,
+            ]);
+            $this->client->addRelated($parent['id'], 'folders', 'children', [
+                [
+                    'id' => (string)Hash::get($response, 'data.id'),
+                    'type' => $type,
+                ],
+            ]);
+            $ids[] = (string)Hash::get($response, 'data.id');
+        }
+        foreach ($ids as $id) {
+            $config = [
+                'environment' => [
+                    'REQUEST_METHOD' => 'GET',
+                ],
+                'get' => [],
+                'params' => compact('type', 'id'),
+            ];
+            $request = new ServerRequest($config);
+            $tree = new TreeController($request);
+            $tree->parents($type, $id);
+            $actual = $tree->viewBuilder()->getVar('parents');
+            $actual = $actual[0];
+            static::assertNotEmpty($actual);
+            static::assertEquals('folders', $actual['type']);
+            static::assertEquals($parent['id'], $actual['id']);
+        }
+    }
+
+    /**
+     * Test `parents` method on exception
+     *
+     * @return void
+     * @covers ::parents()
+     * @covers ::fetchParentsData()
+     */
+    public function testParentsException(): void
+    {
+        $this->setupApi();
+        $type = 'documents';
+        $id = '99999999999';
+        $config = [
+            'environment' => [
+                'REQUEST_METHOD' => 'GET',
+            ],
+            'get' => [],
+            'params' => compact('type', 'id'),
+        ];
+        $request = new ServerRequest($config);
+        $tree = new TreeController($request);
+        $tree->parents($type, $id);
+        $actual = $tree->viewBuilder()->getVar('parents');
+        static::assertEmpty($actual);
+    }
 }

From 81165995e2de7fde1d936b12931b7b1ac2a8ffef Mon Sep 17 00:00:00 2001
From: dante di domenico <dante@didoda.com>
Date: Tue, 19 Mar 2024 10:12:39 +0100
Subject: [PATCH 2/5] tests: fix testDataException

---
 tests/TestCase/Controller/TreeControllerTest.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestCase/Controller/TreeControllerTest.php b/tests/TestCase/Controller/TreeControllerTest.php
index c6801e060..4c6097565 100644
--- a/tests/TestCase/Controller/TreeControllerTest.php
+++ b/tests/TestCase/Controller/TreeControllerTest.php
@@ -80,11 +80,11 @@ public function testDataException(): void
                 'REQUEST_METHOD' => 'GET',
             ],
             'get' => [],
-            'query' => ['filter' => ['parent' => 999], 'pageSize' => 10],
+            'query' => [],
         ];
         $request = new ServerRequest($config);
         $tree = new class ($request) extends TreeController {
-            public function fetchData(array $query): array
+            public function fetchTreeData(array $query): array
             {
                 throw new BEditaClientException('test exception');
             }

From 20f9071acf371a5a6d6cdc063fad35f0ec1b4d70 Mon Sep 17 00:00:00 2001
From: dante di domenico <dante@didoda.com>
Date: Tue, 19 Mar 2024 10:22:56 +0100
Subject: [PATCH 3/5] tests: more coverage

---
 .../Controller/TreeControllerTest.php         | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/tests/TestCase/Controller/TreeControllerTest.php b/tests/TestCase/Controller/TreeControllerTest.php
index 4c6097565..a5e413046 100644
--- a/tests/TestCase/Controller/TreeControllerTest.php
+++ b/tests/TestCase/Controller/TreeControllerTest.php
@@ -15,7 +15,10 @@
 namespace App\Test\TestCase\Controller;
 
 use App\Controller\TreeController;
+use App\Event\TreeCacheEventHandler;
+use App\Utility\CacheTools;
 use BEdita\SDK\BEditaClientException;
+use Cake\Cache\Cache;
 use Cake\Http\ServerRequest;
 use Cake\Utility\Hash;
 
@@ -314,4 +317,37 @@ public function testParentsException(): void
         $actual = $tree->viewBuilder()->getVar('parents');
         static::assertEmpty($actual);
     }
+
+    /**
+     * Test `minimalData` method
+     *
+     * @return void
+     * @covers ::minimalData()
+     */
+    public function testMinimalDataEmpty(): void
+    {
+        $this->setupApi();
+        $id = 'mytestid';
+        $key = CacheTools::cacheKey(sprintf('tree-node-%s', $id));
+        Cache::write($key, [], TreeCacheEventHandler::CACHE_CONFIG);
+
+        $config = [
+            'environment' => [
+                'REQUEST_METHOD' => 'GET',
+            ],
+            'get' => [],
+            'params' => compact('id'),
+        ];
+        $request = new ServerRequest($config);
+        $tree = new class ($request) extends TreeController
+        {
+            public function minData(array $data): array
+            {
+                return $this->minimalData($data);
+            }
+        };
+        $actual = $tree->minData([]);
+        static::assertEmpty($actual);
+
+    }
 }

From 383b19aa33e0e030128567a61f5e90a1919c1735 Mon Sep 17 00:00:00 2001
From: dante di domenico <dante@didoda.com>
Date: Tue, 19 Mar 2024 10:27:38 +0100
Subject: [PATCH 4/5] chore fix: phpcs

---
 tests/TestCase/Controller/TreeControllerTest.php | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/TestCase/Controller/TreeControllerTest.php b/tests/TestCase/Controller/TreeControllerTest.php
index a5e413046..616afbcbf 100644
--- a/tests/TestCase/Controller/TreeControllerTest.php
+++ b/tests/TestCase/Controller/TreeControllerTest.php
@@ -348,6 +348,5 @@ public function minData(array $data): array
         };
         $actual = $tree->minData([]);
         static::assertEmpty($actual);
-
     }
 }

From 2ae73affa60c247e74ab190519b2714606fb1335 Mon Sep 17 00:00:00 2001
From: dante di domenico <dante@didoda.com>
Date: Tue, 19 Mar 2024 10:40:36 +0100
Subject: [PATCH 5/5] fix: folder-picker

---
 resources/js/app/components/folder-picker/folder-picker.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/resources/js/app/components/folder-picker/folder-picker.js b/resources/js/app/components/folder-picker/folder-picker.js
index 15b9d0e63..1217283af 100644
--- a/resources/js/app/components/folder-picker/folder-picker.js
+++ b/resources/js/app/components/folder-picker/folder-picker.js
@@ -75,7 +75,8 @@ export default {
             const pageSize = 100;
             const filter = !parent ? 'filter[roots]' : `filter[parent]=${parent.id}`;
             const firstResponse = await fetch(`${API_URL}tree?${filter}&page=1&page_size=${pageSize}`, API_OPTIONS);
-            const json = await firstResponse.json();
+            let json = await firstResponse.json();
+            json = json.tree || {};
             const folders = [...(json.data || [])];
             const pageCount = json.meta.pagination.page_count;