Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Oakland Raiders to Las Vegas Raiders in teamcolors dataframe #22

Closed
benjaminrobinson opened this issue Mar 30, 2020 · 8 comments
Closed

Comments

@benjaminrobinson
Copy link

Just thought I'd put this request in since the base teamcolors dataset will need to change to accurately reflect the Raiders move from Oakland to Las Vegas. Thanks for this package guys!

@beanumber
Copy link
Owner

Thanks I will fix it as soon as I get a chance

@benjaminrobinson
Copy link
Author

benjaminrobinson commented Mar 31, 2020

Thanks, @beanumber! I wrote some code to get around this for the time being but would be great if I didn't have to!

@JTGamber89
Copy link

In the same vein, the Washington Redskins ought to be renamed to be the Washington Football Team, pending their re-brand in 2022. Thanks for the great package!

@benjaminrobinson
Copy link
Author

The other thing here is that the teams in the English Premier League change each year, making the EPL section of this package moot as not all current EPL teams are included.

@gjm112
Copy link
Collaborator

gjm112 commented Jul 25, 2021 via email

@benjaminrobinson
Copy link
Author

For this year, you're missing:

- Norwich City
- Leeds United
- Brentford FC
- Aston Villa
- Wolverhampton Wanderers

Might be worthwhile adding all EPL clubs ever?
premierleague.com/clubs

I did a diff and these are the 30 others teams you're missing from all teams who've ever participated in EPL football:

- Aston Villa
- Barnsley
- Birmingham City
- Blackburn Rovers
- Blackpool
- Bolton Wanderers
- Bradford City
- Brentford
- Cardiff City
- Charlton Athletic
- Coventry City
- Derby County
- Fulham
- Hull City
- Ipswich Town
- Leeds United
- Middlesbrough
- Norwich City
- Nottingham Forest
- Oldham Athletic
- Portsmouth
- Queens Park Rangers
- Reading
- Sheffield United
- Sheffield Wednesday
- Sunderland
- Swindon Town
- Wigan Athletic
- Wimbledon
- Wolverhampton Wanderers

@gjm112
Copy link
Collaborator

gjm112 commented Jul 25, 2021 via email

@beanumber
Copy link
Owner

See also #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants