Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older seedlots not updating new BV data #1667

Open
SLDonnelly opened this issue Oct 10, 2024 · 5 comments · May be fixed by #1690
Open

Older seedlots not updating new BV data #1667

SLDonnelly opened this issue Oct 10, 2024 · 5 comments · May be fixed by #1690
Assignees
Labels
bug Something isn't working

Comments

@SLDonnelly
Copy link
Collaborator

Describe the Bug
Breeding values were update for Sitka spruce (Ss), so when I open the record, put it in edit mode and click on the recalculate button it should update the new breeding values from the oracle API and then recalculate the GW traits

Expected Behaviour
When I open a record in review mode and click recalculate, new BV should be pulled and the new GW should be recalculated

Actual Behaviour
The system is spinning and not pulling data

Image

@SLDonnelly SLDonnelly added the bug Something isn't working label Oct 10, 2024
@SLDonnelly
Copy link
Collaborator Author

Opened PR for this request is here: https://github.com/bcgov/nr-spar/pull/1669

@SLDonnelly
Copy link
Collaborator Author

Previous changes in the PR didn't fix the issue. Ricardo found the following. @mgaseta would you be able to follow up on Ricardo's work and see if we can complete this issue?

here's the new issue:
Image

@mgaseta
Copy link
Collaborator

mgaseta commented Oct 17, 2024

Sure! I'll get right into it.

@mgaseta mgaseta linked a pull request Oct 22, 2024 that will close this issue
3 tasks
@mgaseta mgaseta linked a pull request Oct 22, 2024 that will close this issue
3 tasks
@SLDonnelly
Copy link
Collaborator Author

Hi @mgaseta I've tested your PR. The recalculate section is now working and doesn't get stuck :) However it looks like the form isn't pulling in new breeding values. These are the testing steps that I took:

  1. created a new seedlot and registered it
  2. Approved the seedlots
  3. Opened old SPAR to update the breeding values for Sitka Spruce trees in orchard 172
  4. Reopened the seedlot registration form in SPAR2
  5. In the review and edit view, I clicked on recalculted

The Expected result is that new breeding values are brought up (see several GVO values updated from 2 to 10)

screen-recorder-tue-oct-22-2024-15-07-03.webm

Image

@mgaseta
Copy link
Collaborator

mgaseta commented Nov 4, 2024

As agreed on our sprint planning, this issue will only tackle the infinite loading problem, the wrong breading value issue will be tackled on issue #1704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment