From d0bb7c55244131c8a4109249ab8acbea03aa7ba3 Mon Sep 17 00:00:00 2001
From: abimichel <abigail.michel@gov.bc.ca>
Date: Wed, 31 Jan 2024 13:26:10 -0800
Subject: [PATCH] no longer need the image pull secret

---
 .../deps/charts/opensearch-2.12.1/values.yaml | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/charts/deps/charts/opensearch-2.12.1/values.yaml b/charts/deps/charts/opensearch-2.12.1/values.yaml
index 507e3ad..37be863 100644
--- a/charts/deps/charts/opensearch-2.12.1/values.yaml
+++ b/charts/deps/charts/opensearch-2.12.1/values.yaml
@@ -22,7 +22,7 @@ roles:
 replicas: 1 # Abi: previously 3
 
 # if not set, falls back to parsing .Values.imageTag, then .Chart.appVersion.
-majorVersion: 2.7.0 # Abi: Chart.appversion = 2.7.0
+majorVersion: 2.7.0 # Abi: Chart.appVersion = 2.7.0
 
 global:
   # Set if you want to change the default docker registry, e.g. a private one.
@@ -126,8 +126,8 @@ hostAliases: []
 image:
   repository: ghcr.io/bcgov/nr-openmetadata-opensearch # Abi: previously "opensearchproject/opensearch"
   # override image tag, which is .Chart.AppVersion by default
-  tag: security-context-changes # Abi: was previously defaulting to version # 2.7.0
-  pullPolicy: "Always"
+  tag: security-context-changes # Abi: previously defaulting 2.7.0
+  pullPolicy: "Always" # Abi: prevously "IfNotPresent"
 
 podAnnotations: {}
   # iam.amazonaws.com/role: es-cluster
@@ -190,11 +190,11 @@ podSecurityPolicy:
 persistence:
   enabled: true
   # Set to false to disable the `fsgroup-volume` initContainer that will update permissions on the persistent disk.
-  enableInitChown: false # Abi: disables line 234 on the statefulset.yaml, as permissions are now handled with custom dockerfile for random UID
+  enableInitChown: false # Abi: disables line 234 on the statefulset.yaml
   # override image, which is busybox by default
-  image: ghcr.io/bcgov/nr-openmetadata-opensearch-busybox # Abi: set to main branch after PR merge
+  image: ghcr.io/bcgov/nr-openmetadata-opensearch-busybox # Abi: previously busybox:latest
   # override image tag, which is latest by default
-  imageTag: security-context-changes # will become main
+  imageTag: security-context-changes # Abi: set to main branch after PR merge
   labels:
     # Add default labels for the volumeClaimTemplate of the StatefulSet
     enabled: false
@@ -296,8 +296,8 @@ updateStrategy: RollingUpdate
 # of your pods to be unavailable during maintenance
 # maxUnavailable: 1 # Abi: removed PDB for now
 
-podSecurityContext: # Abi: removed runAsUser: 0 from initContainer in statefulset.yaml
-  # fsGroup: 1000 # Abi: allow for GID=0
+podSecurityContext: 
+  # fsGroup: 1000 # Abi: allow for  group ID 0
   # runAsUser: 1000 # Abi: allow for random UID 
 
 securityContext:
@@ -375,8 +375,7 @@ readinessProbe:
 ##
 schedulerName: ""
 
-imagePullSecrets: 
-  - name: "artifactory-pull"
+imagePullSecrets: []
 nodeSelector: {}
 tolerations: []