Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can't create private routes by default #111

Open
rustyjux opened this issue Apr 11, 2024 · 0 comments
Open

Users can't create private routes by default #111

rustyjux opened this issue Apr 11, 2024 · 0 comments
Labels
bug Something isn't working jira

Comments

@rustyjux
Copy link
Contributor

rustyjux commented Apr 11, 2024

By default, users can't create private routes (where route hosts end in .cluster.local which creates a route .svc.cluster.local). As is, it is necessary to go into keycloak authz and add .svc.cluster.local to perm-domains.

The issue likely lies in validate_hosts() here -

def validate_hosts(yaml, reserved_hosts, ns_attributes):

Resolution could include adding .svc.cluster.local to the default list of allowed_domains or otherwise modifying the function logic.

I have a note from a conversation with Aidan that the issue may be a misplaced if statement (should be else) following the if statement checking if it’s a valid local route, but I'm not soo sure about this.

@rustyjux rustyjux added bug Something isn't working jira labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jira
Projects
None yet
Development

No branches or pull requests

1 participant