Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The refresh_swrs_data() function uses the incorrect init functions for older form_json templates #1982

Open
dleard opened this issue Sep 20, 2021 · 0 comments
Labels
Bug Something isn't working

Comments

@dleard
Copy link
Contributor

dleard commented Sep 20, 2021

When we created a new form_json template for the admin-2020 data, we reworked the init function for admin. This means all applications will use the function designed for 2020 data when refreshing the version 0.

What we should have done (and should do going forward) is create a new init function for that form_json when we create new form_json templates.
We will also likely have to create new get_swrs_*_data() functions as well.

To fix the current bug, the old, re-worked init_application_administration_form_result() function should be created as a 2019 specific function & the 2019 form_json should use that function.
The get_swrs functions relating to admin data will also need to be looked at in case there are some changes needed to those as well.

This is a minor issue for now since the changes to the admin form in 2020 shouldn't have much effect on the overall experience in-app.

Probability (1-5): 5
Effect (1-5): 1

@dleard dleard added the Bug Something isn't working label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant