Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to include non-scss dependencies such as typography files for font-face #14

Open
KyleLehtinenDev opened this issue Nov 6, 2017 · 1 comment

Comments

@KyleLehtinenDev
Copy link

While writing an scss file that defined some custom font-face rules for my company's custom fonts it became apparent that the sass_library/binary rule do not have a "data" attribute where one could reference the dependent typography files. I wasn't able to use the dependency attribute either since that attribute appears to be written to only handle scss imports.

Would it be possible to add a "data" attribute to the rule/s where typography files referenced in font-face definitions can be passed, or is there another way I should go about doing this? I thought about handling the files with filegroup or genrule to make sure they ended up where the font-face rule expected to find them, but didn't like how this appeared to disassociate the required/dependent typography files from the scss rules that references them.

@jbedard
Copy link

jbedard commented Jan 18, 2019

Any updates or recommendations on this?

gonzojive pushed a commit to gonzojive/rules_sass that referenced this issue Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants