-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crate_vendor is broken in recent releases #2932
Comments
Would you please share your relevant MODULE config and your //third_party/BUILD.bazel file? The thing is, there are 4 different ways to vendor in rules_rust: from_crate (using cargo.toml)
from_spec (using direct deps in BUILD.bazel)
In a nutshell, remote vendoring requires an extra script to run correctly, see this example: https://github.com/bazelbuild/rules_rust/tree/main/examples/bzlmod/all_deps_vendor Also, remote vendoring can be leaky meaning vendored deps may update during regular builds. Local vendoring, that means the deps are correctly stored in the thirdparty/crate folder, doesn't need a script and is not leaky meaning vendored deps only update when you call the vendor target. See this example for local from_spec vendoring. The other thing is, if you use vendoring with from_crate (and a Cargo.toml), then it takes a bit more research because the bazelmod examples have not been added yet. I know the documentation isn't super clear in this area, but afaik, if you configure proper local vendoring stuff just builds. |
setting
bootstrap = True
incrate_universe_dependencies
fails for not being able to find cargo:as we are using nightly toolchains:
I haven't dug into the issue, but this is a change between 0.49.3 and 0.52.2.
The text was updated successfully, but these errors were encountered: