Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a documentation bzl_library publicly visible #565

Closed
guw opened this issue Apr 3, 2022 · 2 comments · Fixed by #567
Closed

Make a documentation bzl_library publicly visible #565

guw opened this issue Apr 3, 2022 · 2 comments · Fixed by #567

Comments

@guw
Copy link
Contributor

guw commented Apr 3, 2022 •
edited
Loading

It's unfortunate but the concept of private breaks other tools (eg. Stardoc).
bazelbuild/stardoc#93

An alternative could be to expose a public bzl_library
@guw guw changed the title Increase visibility of all .bzl files to public. Make a documentation bzl_library publicly visible Apr 3, 2022
guw added a commit to guw/rules_pkg that referenced this issue Apr 3, 2022
@guw
Make bzl_library public for Stardoc
0541b09 
Workaround for bazelbuild/stardoc#93.
Fixes bazelbuild#565
@guw guw mentioned this issue Apr 3, 2022
Closed
@aiuto
Copy link
Collaborator

aiuto commented Apr 4, 2022

Take a look at #567. I had that ready to send while waiting for other PRs to get merged.

@aiuto aiuto mentioned this issue Apr 6, 2022
Merged
@aiuto
Copy link
Collaborator

aiuto commented Apr 6, 2022

Duplicate of #564

@aiuto aiuto marked this as a duplicate of #564 Apr 6, 2022
@aiuto aiuto closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@guw @aiuto