Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InferenceNetwork.call does not forward its arguments #204

Closed
vpratz opened this issue Oct 10, 2024 · 1 comment
Closed

InferenceNetwork.call does not forward its arguments #204

vpratz opened this issue Oct 10, 2024 · 1 comment
Assignees
@stefanradev93 @LarsKue
Labels
question Further information is requested refactoring Some code shall be redesigned v2 Issues related to the bayesflow v2 refactor

Comments

@vpratz
Copy link
Collaborator

vpratz commented Oct 10, 2024 •
edited
Loading

The default implementation of InferenceNetwork.call takes conditions and density as parameters, but does neither use them nor pass them on to self._forward and self._inverse. This seems not intuitive to me, was this done on purpose or should we forward those parameters to these functions?
@marvinschmitt
Copy link
Member

tagging @LarsKue and @stefanradev93 who designed that initially

@marvinschmitt marvinschmitt added question Further information is requested refactoring Some code shall be redesigned v2 Issues related to the bayesflow v2 refactor labels Oct 10, 2024
@marvinschmitt marvinschmitt changed the title InferenceNetwork.call does not forward its arguments (version 2.0) InferenceNetwork.call does not forward its arguments Oct 10, 2024
LarsKue added a commit that referenced this issue Nov 5, 2024
@LarsKue
fix #204
d05c328
@LarsKue LarsKue closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanradev93 stefanradev93

@LarsKue LarsKue

Labels
question Further information is requested refactoring Some code shall be redesigned v2 Issues related to the bayesflow v2 refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stefanradev93 @marvinschmitt @LarsKue @vpratz