Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space transformations refactor #449

Merged
merged 19 commits into from
Oct 19, 2024
Merged

Conversation

Micki-D
Copy link
Collaborator

@Micki-D Micki-D commented Sep 2, 2024

This PR incorporates the changes from PR #409, and also includes structural changes of the type structure for mcmc samplers.

E.g.:
"-Iterator" -> "-State"

"Sampling" and "Tuning" are structs that hold the config data for a MCMC sampling and tuning Process, and for the actual execution of the sampling, "MCMCState", and "TunerState" objects are created that hold the concrete data for the process.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 79.75460% with 132 lines in your changes missing coverage. Please review.

Project coverage is 48.39%. Comparing base (3767f31) to head (eb950ea).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/samplers/mcmc/mcmc_algorithm.jl 44.00% 28 Missing ⚠️
...amplers/mcmc/mcmc_tuning/mcmc_adaptive_mh_tuner.jl 74.64% 18 Missing ⚠️
src/samplers/mcmc/mcmc_tuning/mcmc_noop_tuner.jl 0.00% 17 Missing ⚠️
src/samplers/mcmc/mcmc_tuning/mcmc_ram_tuner.jl 72.34% 13 Missing ⚠️
src/samplers/mcmc/mcmc_utils.jl 48.00% 13 Missing ⚠️
src/samplers/mcmc/mcmc_state.jl 93.49% 11 Missing ⚠️
src/samplers/mcmc/chain_pool_init.jl 86.27% 7 Missing ⚠️
ext/ahmc_impl/ahmc_tuner_impl.jl 88.37% 5 Missing ⚠️
src/samplers/mcmc/mcmc_sample.jl 81.81% 4 Missing ⚠️
src/measures/bat_pushfwd_measure.jl 50.00% 3 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
+ Coverage   47.36%   48.39%   +1.03%     
==========================================
  Files         112      118       +6     
  Lines        5422     5558     +136     
==========================================
+ Hits         2568     2690     +122     
- Misses       2854     2868      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.gitignore Outdated Show resolved Hide resolved
docs/src/tutorial_lit.jl Outdated Show resolved Hide resolved
@oschulz
Copy link
Member

oschulz commented Oct 17, 2024

Let's use samplingalg instead of sampling for argument and variable names, it's clearer.

@oschulz oschulz merged commit 0f0563f into bat:main Oct 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants