-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Possible "hide entries" behavior bug. #418
Comments
Thank you for the bug report. Would you like to contribute your solution as a pull request? |
Yes. I modified the function slightly so that only Pull request is here: #419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using the monthly org-journal mode, when
org-journal-hide-entries-p
isnil
, runningorg-journal-new-entry
hides any expanded sections that are not in the current date.To Reproduce
Steps to reproduce the behavior:
org-journal-file-type
tomonthly
andorg-journal-hide-entries-p
tonil
org-journal-new-entry
Running
org-journal-new-entry
leads to theThursday
entry being hidden, which shouldn't happen due toorg-journal-hide-entries-p
beingnil
.Expected behavior
Expected behavior is to have none of the sections collapsed when creating a new entry. The documentation states:
Which makes me assume that no entries will be hidden / collapsed when creating a new one.
One possible solution to this is to change the function
org-jounal--finalize-view
(which is called inorg-journal-new-entry
) to the following:Which fixes my issue, but I'm not sure if it would mess with anything else.
Desktop (please complete the following information):
Your Emacs Configuration
Using DOOM-Emacs. Downloaded
org-journal
via thepackage!
macro.The text was updated successfully, but these errors were encountered: