Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 1.19 is purely fictional. #196

Closed
MajliTech opened this issue May 30, 2023 · 5 comments
Closed

Support for 1.19 is purely fictional. #196

MajliTech opened this issue May 30, 2023 · 5 comments

Comments

@MajliTech
Copy link

I couldn't get sending chat as a client from unsupported 1.19.4, 1.19.3 or 1.19.2. The fact that this is marked as a supported is kinda wrong, because when sending chat the kick message is:
Internal Exception: io.netty.handler.codec.DecoderException: java.lang.IndexOutOfBoundsException: readerIndex(24) + length(8) exceeds writerIndex(24): PooledUnsafeDirectByteBuf(ridx: 24, widx: 24, cap: 24)
This project is abandoned, and someone with enough Minecraft and Python skills, time and patience should take it over.

@MajliTech MajliTech changed the title Support for 1.19 is puerly fictional. Support for 1.19 is purely fictional. May 30, 2023
@MajliTech
Copy link
Author

#191 should also be noted

@dries007
Copy link
Collaborator

Where do you see it mentioned that 1.19.3 or 1.19.4 is supported? It's not in the readme or release notes, so the fictional support is entirely a figment of your imagination.

I know for a fact 1.19, 1.19.1 and 1.19.2 work (at least for rudimentary chat stuff), as I use it for MCLink. It's possible there are bugs with the chat example code, but I don't think so as I generally test that before making a release.

@MajliTech
Copy link
Author

Ok, but even for 1.19.2, it ain't working

@MajliTech
Copy link
Author

Ok, now I know where I got 1.19.3 someone made a try to add support.

@dries007
Copy link
Collaborator

Considering I'm actively using it without issues at the moment, I tend to disagree. As released, 1.19.2 works. It might require some tweaks to get all the features you need to work, but the basics are there.

As for the 1.19.3/1.19.4 support: There is a merge request, but that's not in a mergeable state. If you want to be of help, try to get that working and make your own merge request or issue with description of what needs to change to implement support.
The best resources are the existing code and wiki.vg. Good luck; have fun. I guess you'll find out soon enough why it sometimes takes so long to get a new version supported. I've worked a bit on and off on the support for the missing 1.19.x versions, but have not gotten very far.

As a sidenote: Please stop spamming issues with comments, unless you actually have a solution to a problem. All this activity just creates email/notification spam, which then leads to the project being more ignored by the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants