Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.8 #713

Closed
tomicapretto opened this issue Aug 26, 2023 · 3 comments · Fixed by #720
Closed

Drop support for Python 3.8 #713

tomicapretto opened this issue Aug 26, 2023 · 3 comments · Fixed by #720
Labels
good first issue If you want to contribute but are not sure where to get started, this issue is for you!

Comments

@tomicapretto
Copy link
Collaborator

Right now our tests run on 3.8, 3.9, and 3.10. They should run on 3.9, 3.10, and 3.11.
@tomicapretto tomicapretto added the good first issue If you want to contribute but are not sure where to get started, this issue is for you! label Aug 26, 2023
@5hv5hvnk
Copy link

We just need a small edit here right?

@tomicapretto
Copy link
Collaborator Author

@5hv5hvnk yes! And also this line

bambi/pyproject.toml

Line 70 in ae00f26

target-version = ["py38", "py39", "py310"]

@tomicapretto tomicapretto mentioned this issue Sep 14, 2023
Merged
@tomicapretto
Copy link
Collaborator Author

Hi @5hv5hvnk I'm doing this in #720 because my CI was broken since one of the libraries we use to build the docs doesn't support Python 3.8 anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue If you want to contribute but are not sure where to get started, this issue is for you!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update quartodoc to fix CI tomicapretto/bambi
2 participants
@5hv5hvnk @tomicapretto