Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citation Style issue with Group Label Elements #3852

Closed
tadean opened this issue Nov 1, 2024 · 0 comments · Fixed by #3853
Closed

Citation Style issue with Group Label Elements #3852

tadean opened this issue Nov 1, 2024 · 0 comments · Fixed by #3853
Assignees
Labels
patch release Issues to be included in the next patch release publications

Comments

@tadean
Copy link
Contributor

tadean commented Nov 1, 2024

Problem/Motivation

For citation styles which use label elements in groups, sometimes the conditional aspect of groups is not present. This is notable in the APA style. For a book publication which has no volume, the style's volume-booklike macro implicitly outputs the not-present number-of-volumes property, resulting in an output of 1–

Wildcat, W. (2024). History of Wildcats. In Wildcat Anthology (Version V1, 1–, Issues 4, pp. 200-230). The University of Arizona Press.

Describe the bug

Group rendering of seboettg/citeproc-php currently does not seem to take into account the conditional nature of a Group element which contains a Label. This is explained in seboettg/citeproc-php#158

To Reproduce

Create a book publication with no volume, while using the APA style.

Expected behavior

Wildcat, W. (2024). History of Wildcats. In Wildcat Anthology (Version V1, Issues 4, pp. 200-230). The University of Arizona Press.

@tadean tadean added patch release Issues to be included in the next patch release publications labels Nov 1, 2024
@tadean tadean self-assigned this Nov 1, 2024
tadean pushed a commit that referenced this issue Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Issues to be included in the next patch release publications
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant