Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellcheck step to PR process. #63

Open
trackleft opened this issue Apr 25, 2022 · 0 comments
Open

Add shellcheck step to PR process. #63

trackleft opened this issue Apr 25, 2022 · 0 comments

Comments

@trackleft
Copy link
Member

Motivation

It would be good to find errors in our bash script files before updating the main branch.

Is your feature request related to a problem? Please describe.

This is more of a prevention step to make it easier for non bash experts to contribute bash scripts to the project.

Proposed Resolution

Use something similar to this.

name: Pull request checks
on: pull_request

jobs:
  lint-bash:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@v1
      - name: Run ShellCheck
        uses: azohra/[email protected]
        with:
          exclude-paths: Dockerfile, .github/CODEOWNERS, .github/ISSUE_TEMPLATE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant