Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Serilog 3.0.0 #222

Open
1 of 2 tasks
Xilconic opened this issue Jun 20, 2023 · 2 comments
Open
1 of 2 tasks

Support Serilog 3.0.0 #222

Xilconic opened this issue Jun 20, 2023 · 2 comments
Labels
feature-request A feature should be added or improved. module/logging p2 This is a standard priority issue queued

Comments

@Xilconic
Copy link

Describe the feature

Serilog 3.0.0 has been released on June 20th 1:01 AM GMT+2. Changelog: https://github.com/serilog/serilog/releases/tag/v3.0.0

AWS.Logger.SeriLog currently supports Serilog v2.6.0 and up.

The major version release of Serilog does come with breaking changes.

Use Case

Aiming to keep up with current developments in dependencies we use, to security minimize risks and benefiting from performance improvements.

Proposed Solution

Update the dependency on Serilog to version 3.0.0 and fix breaking changes.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

AWS.Logger.SeriLog v3.2.0

Targeted .NET Platform

.NET6

Operating System and version

AmazonLinux, Windows 10
@Xilconic Xilconic added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 20, 2023
@ashishdhingra
Copy link
Contributor

Thanks for submitting feature request. This needs review with the team.

@ashishdhingra ashishdhingra added needs-review and removed needs-triage This issue or PR still needs to be triaged. labels Jun 20, 2023
@ashishdhingra
Copy link
Contributor

Needs reproduction if our HLL has issues when customer upgrades to Serilog 3.0.0.

@ashishdhingra ashishdhingra added p2 This is a standard priority issue queued and removed needs-review labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. module/logging p2 This is a standard priority issue queued
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xilconic @ashishdhingra