-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically get network interface name in domainjoin_unix_script.go #469
Comments
Thanks for the feedback @DanielTeraSky , the second option looks more portable. |
When you submit the PR, also mention what testing you have done. |
Thanks for opening this issue @DanielTeraSky - the interface name ( A potential solution may be setting an
I have come up with a hacky workaround for my builds in the interim but unfortunately my bash skills aren't up to par to submit a PR for this. edit: disregard, i see your PR has now been merged. Opened PR #499 as a follow up |
The PR has been pushed, it may take sometime to deploy to all regions, please keep your agent uptodate. |
You are right, for Ubuntu, there is one more spot where eth0 has not been fixed. |
As part of the domain join script for Unix, there is a line where we get the interface IP address, but the interface name is hard-coded (
eth0
) as you can see here:amazon-ssm-agent/agent/plugins/domainjoin/domainjoin_unix_script.go
Line 555 in baf58f0
Although this works for
t2
instance types, it doesn't work fort3
andt3a
since the network interface name has changed toensX
.I suggest to change this line to dynamically fetch the the IP without specifying the interface name.
There are 2 options to do this:
This is an important fix as there is currently an issue with this script when running on newer machine types
The text was updated successfully, but these errors were encountered: