Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf.aliasing support #1026

Open
steeve opened this issue Nov 4, 2024 · 0 comments
Open

tf.aliasing support #1026

steeve opened this issue Nov 4, 2024 · 0 comments

Comments

@steeve
Copy link

steeve commented Nov 4, 2024

Hi,

We (@zml) found that tf.aliasing support seemed to be not working as expected, with the model producing garbage when used. In our case Llama 3.1 8B.
This is problematic for transformer models because we leverage donations for the KvCache.

For now we're not emitting those attributes when on neuron, but we're not sure what to do as we feel that if the SDK doesn't support them, it should just ignore them right ?

The llama implementation is attached.

Thank you !

llama.aliasing.mlir.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant