Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react 19 support #6084

Open
oste opened this issue Nov 14, 2024 · 3 comments
Open

react 19 support #6084

oste opened this issue Nov 14, 2024 · 3 comments
Labels
feature-request Request a new feature React An issue or a feature-request for React platform

Comments

@oste
Copy link

oste commented Nov 14, 2024

As expected, I'm encountering a dependency error when running npm install with the latest versions of Next.js and React 19 RC. I'm wondering if there’s a way to make Amplify UI work with React 19, or if there’s a planned roadmap for adding support for react 19. Thanks!

npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/react
npm error   react@"19.0.0-rc-66855b96-20241106" from [email protected]
npm error   apps/blog
npm error     [email protected]
npm error     node_modules/blog
npm error       workspace apps/blog from the root project
npm error
npm error Could not resolve dependency:
npm error peer react@"^16.14.0 || ^17.0 || ^18.0" from @aws-amplify/[email protected]
npm error node_modules/@aws-amplify/ui-react
npm error   @aws-amplify/ui-react@"^6.5.5" from [email protected]
npm error   apps/blog
npm error     [email protected]
npm error     node_modules/blog
npm error       workspace apps/blog from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
@github-actions github-actions bot added pending-triage Issue is pending triage pending-maintainer-response Issue is pending response from an Amplify UI maintainer labels Nov 14, 2024
@cwomack cwomack added feature-request Request a new feature React An issue or a feature-request for React platform and removed pending-triage Issue is pending triage pending-maintainer-response Issue is pending response from an Amplify UI maintainer labels Nov 14, 2024
@cwomack
Copy link
Member

cwomack commented Nov 14, 2024

Hello, @oste and thank you for opening this issue. We'll mark this as a feature request since the versions mentioned here are still release candidates, but we'll update this issue as soon as we have support for the released versions. Thanks!

If you're using JavaScript, things should still work but this has not been fully tested yet. Per the error message you've listed, you can use the --legacy-peer-deps command as well to test this if you'd like.

@oste
Copy link
Author

oste commented Nov 15, 2024

I did try legacy peer deps but didn’t have success but maybe that’s another issue with my dependency tree

@github-actions github-actions bot added the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Nov 15, 2024
@dindjarinjs
Copy link
Contributor

dindjarinjs commented Nov 15, 2024

Just tried the following commands and I didn't get any errors:

npx create-next-app test-react-19 # creates a Nextjs project using React 19RC
cd test-react-19
npm install aws-amplify @aws-amplify/ui-react --legacy-peer-deps

Output:

➜  test-react-19 git:(main) npm install aws-amplify @aws-amplify/ui-react --legacy-peer-deps
added 232 packages, and audited 269 packages in 10s

16 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Maybe try --force? What version of npm are you using? I'm using npm 10.2.4.

@github-actions github-actions bot removed the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request a new feature React An issue or a feature-request for React platform
Projects
None yet
Development

No branches or pull requests

3 participants