Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove weird chapter_id code #534

Open
jcn opened this issue Mar 17, 2023 · 0 comments
Open

Fix/remove weird chapter_id code #534

jcn opened this issue Mar 17, 2023 · 0 comments
Labels

Comments

@jcn
Copy link
Member

jcn commented Mar 17, 2023

The fix_chapter_ids code is weird and should be removed/fixed but I'm not sure the implications of it. When viewing project pages, this before_action changes the id param from the full param (with the title) to just the id.

https://github.com/awesomefoundation/awesomebits/blob/master/app/controllers/application_controller.rb#L56-L66

This code was put in a long time ago and I'm not sure how necessary it is any more. It may have just been transitional when moving from chapter ids to friendly_id slugs.

@jcn jcn added the bug label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant