Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

av pr create fails if the parent branch is merged and not synced #305

Open
draftcode opened this issue May 28, 2024 · 2 comments
Open

av pr create fails if the parent branch is merged and not synced #305

draftcode opened this issue May 28, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@draftcode
Copy link
Contributor

It's better to detect this and explain that rather than saying "Head sha can't be blank, Base sha can't be blank, No commits between buildkite_pipeline_config_api and buildkite_api_token, Base ref must be a branch"

@draftcode draftcode added the good first issue Good for newcomers label Jun 17, 2024
Konboi added a commit to Konboi/av that referenced this issue Jun 25, 2024
Konboi added a commit to Konboi/av that referenced this issue Jun 25, 2024
@Konboi
Copy link
Contributor

Konboi commented Jun 25, 2024

I have a question about this issue.
Do you suggest handling the error messages from the API (GraphQL Error message) in more detail? Or do you have any other ideas?

@draftcode
Copy link
Contributor Author

Let's first try checking if the parent is merged by checking MergeCommit in the branch metadata.

aviator-app bot pushed a commit that referenced this issue Jun 27, 2024
to detect reason and explain it for #305

(Does this change work as you intended?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants