Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we deal with outdated dependencies? #776

Open
iblech opened this issue Jan 17, 2022 · 4 comments
Open

How should we deal with outdated dependencies? #776

iblech opened this issue Jan 17, 2022 · 4 comments

Comments

@iblech
Copy link

iblech commented Jan 17, 2022

Ethercalc is obviously a terrific and robust piece of software. Lots of people are gaining lots of value from it. :-)

I noticed that the dependencies have not been updated for quite some time now. There has been a pull request, but people felt uneasy merging because of a lack of tests/sufficient testing.

How can we move this forward?

I'd like to spend a bit of time on this. However, I'm not familiar at all with the npm ecosystem, so I couldn't do much more than let npm update bump the version numbers, run ethercalc to see whether it "seems to work" and fix simple problems.

@eddyparkinson
Copy link
Collaborator

eddyparkinson commented Jan 18, 2022 via email

@iblech
Copy link
Author

iblech commented Feb 10, 2022

I guess I'm asking whether a pull request which would bump some of the dependencies would get accepted, even though we don't have a full test suite to check whether everything still works and have to rely on a more informal version of "I ran it locally, everything seemed to work".

@JonasDoe
Copy link

Many libraries document their breaking changes, so generally spoken it's recommendable to check out those in the documentation. Speaking from experience, not all breaking changes are obvious and easy to detect.

@eddyparkinson
Copy link
Collaborator

@iblech This surprised me, with testing, code reviews and manual testing works better than automated testing. People who get good at testing tend to stop using automated tests because they discover that reviews and manual tests are better. There are exceptions, but generally, reviews and manual tests are better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants