Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Absence of line between a list and a code block confuses Markdown Preview #572

Closed
1 task done
piroux opened this issue Aug 23, 2019 · 2 comments
Closed
1 task done

Comments

@piroux
Copy link

piroux commented Aug 23, 2019

Prerequisites

Description

The parser of markdown-preview seems to not recognize well the delimiter of a code block written directly after a list without any empty line, although it is properly handled on Github.
Actually, it seems like markdown-preview is trying to embed the code block at the list level but fail to recognize the end of the code block, whereas Github rendering makes the choice to render all code block outside of the list level.

Steps to Reproduce

  1. Write the following gist in a new tab:
    https://gist.github.com/piroux/0caf3509cd000e254dab357025c9faf1
  2. CTRL+SHIFT+M to activate the vanilla Markown Preview

Edit by @rsese - for step 1, copy paste this content

## ✅ on github.com ✅ on Atom with no line between a list and a code block

- abcd

```
efgh
---
- xyz
  123
```

## ✅ on github.com ❌ on Atom with no line between a list and a code block

- abcd
```
efgh
---
- xyz
  123
```

Expected behavior:

Preview on Atom should match the one offered by Github:
Screenshot from 2019-08-23 10-10-56

Actual behavior:

Screenshot from 2019-08-23 10-13-23

Reproduces how often:
Always

Versions

OS: Ubuntu 18.04 x64
Atom: 1.40.0
Electron: 3.1.10
Chrome: 66.0.3359.181
Node: v10.2.0

Additional Information

Other issues related to code preview already filed here:

@rsese
Copy link

rsese commented Aug 27, 2019

Thanks for the report! Reproduced with 1.42.0-nightly4 on 10.14.6.

@rsese rsese added the triaged label Aug 27, 2019
@rsese
Copy link

rsese commented Aug 27, 2019

Thanks again for the heads up about this - just wanted to mention that we looked at this again today and decided to close in favor of #342 if you want to subscribe there.

@rsese rsese closed this as completed Aug 27, 2019
@rsese rsese added duplicate and removed triaged labels Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants