Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plans to merge with the upstream? #22

Open
alexeyshockov opened this issue Feb 8, 2023 · 3 comments
Open

Plans to merge with the upstream? #22

alexeyshockov opened this issue Feb 8, 2023 · 3 comments

Comments

@alexeyshockov
Copy link

Hey, just wondering, do you have any plans to make a PR to the upstream project, to have the improvements there? IMO maintaining a fork requires some time, and people will always prefer the main line until they really need the benefits of the fork...
@alexeyshockov
Copy link
Author

OK, I see MagicStack#17. Let me know if need any help :) Will be glad to help.

@vmarkovtsev
Copy link
Collaborator

vmarkovtsev commented Feb 8, 2023 •
edited
Loading

Actually, yes, I would very much appreciate some help, thanks. The only missing piece for merging back seems to be making numpy optional. This has to be done inside Cython, I guess. I think everyone expects smth like pip install asyncpg[numpy].

@ale-dd
Copy link

ale-dd commented Sep 12, 2024

@vmarkovtsev & @alexeyshockov: did you lose appetite for the merge? It would be awesome if it happened!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeyshockov @vmarkovtsev @ale-dd