Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review broad Exception and remove this pattern, where possible #257

Open
tatiana opened this issue Oct 17, 2024 · 0 comments
Open

Review broad Exception and remove this pattern, where possible #257

tatiana opened this issue Oct 17, 2024 · 0 comments

Comments

@tatiana
Copy link
Collaborator

tatiana commented Oct 17, 2024

DAG Factory captures broad exceptions in many places, which makes it quite hard to troubleshoot issues:

(venv) ➜  dag-factory git:(fmain) # grep -rn "except Exception" dagfactory
dagfactory/dagbuilder.py:150:        except Exception as err:
dagfactory/dagbuilder.py:296:        except Exception as err:
dagfactory/dagbuilder.py:300:        except Exception as err:
dagfactory/dagbuilder.py:317:        except Exception as err:
dagfactory/dagbuilder.py:561:        except Exception as err:
dagfactory/utils.py:33:    except Exception as err:
dagfactory/dagfactory.py:74:        except Exception as err:
dagfactory/dagfactory.py:111:            except Exception as err:
dagfactory/dagfactory.py:207:        except Exception:  # pylint: disable=broad-except

The goal of this PR is to address this, removing this pattern where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant