Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we add a linting job to the CI, like we have in Purify? #348

Open
SJaffa opened this issue Apr 5, 2023 · 2 comments
Open

Should we add a linting job to the CI, like we have in Purify? #348

SJaffa opened this issue Apr 5, 2023 · 2 comments
Labels
CI

Comments

@SJaffa
Copy link
Contributor

SJaffa commented Apr 5, 2023

No description provided.

@SJaffa SJaffa added the CI label Apr 5, 2023
@SJaffa
Copy link
Contributor Author

SJaffa commented Jun 23, 2023

@krishnakumarg1984 I think you did this somewhere but can't remember which branch it was, could you link a PR to this issue when you make it?

@krishnakumarg1984
Copy link
Collaborator

krishnakumarg1984 commented Jun 23, 2023 •
edited
Loading

@SJaffa It is here.

Note that, this will create a large diff since, for the first run, the linter will reformat and auto-commit the changed codebase. We have to pull down the reformatted development branch, and merge the changed formatting into each of the PRs to be able to merge again.

Let me know your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SJaffa @krishnakumarg1984