Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --preflight-check cmdline option #627

Open
plroebuck opened this issue Oct 14, 2018 · 7 comments
Open

Add --preflight-check cmdline option #627

plroebuck opened this issue Oct 14, 2018 · 7 comments

Comments

@plroebuck
Copy link

AG-B has yet to work on my system. With so many external dependencies involved, maybe add a cmdline option that can query the installation, and report its (both verified and missing) capabilities. Better yet, make this part of package startup and don't execute software that isn't installed...

...
 ✔ 0.000 secs: mergeIdenticalAssets
/bin/sh: line 1: 51401 Segmentation fault: 11  buildProduction docs/_site/index.html --outroot docs/_dist --canonicalroot https://mochajs.org/ --optimizeimages --svgo --inlinehtmlimage 9400 --inlinehtmlscript 0 --asyncscripts
The script called "docs.postbuild" which runs "buildProduction docs/_site/index.html --outroot docs/_dist --canonicalroot https://mochajs.org/ --optimizeimages --svgo --inlinehtmlimage 9400 --inlinehtmlscript 0 --asyncscripts && cp docs/_headers docs/_dist/_headers && node scripts/netlify-headers.js >> docs/_dist/_headers" failed with exit code 139 https://github.com/kentcdodds/nps/blob/v5.9.0/other/ERRORS_AND_WARNINGS.md#failed-with-exit-code
@papandreou
Copy link
Member

Sorry to hear that! We have some long term plans to make a plugin architecture so the user can be more in control of the dependencies, but we haven't gotten around to it yet.

@papandreou
Copy link
Member

Have you tried running it through Docker? https://github.com/assetgraph/assetgraph-builder#docker

@plroebuck
Copy link
Author

Docker. Haven't looked into modifying Mocha's nps scripts to do so yet.

@plroebuck
Copy link
Author

plroebuck commented Oct 14, 2018

I see you have a list of prerequisite binaries/libraries on your site. But anyone just installing Mocha and attempting to build the API documentation website never sees that. And it just fails!

Did you consider wrapping all your dependencies in node-gyp packages and depending on them so everything you need gets installed properly. Or trimming them down to ones that are Node-deployable already? Your docs mention ability to use sharp, but it's not a devDependency?

@Munter
Copy link
Member

Munter commented Oct 18, 2018

I think we can remove some externally install dependencies for jpegtran, pngcrush, optipng and pngquant, since these are all also installed via node scripts. I'd assume those are not the ones causing the troubles though

@Munter
Copy link
Member

Munter commented Oct 18, 2018

We could possible remove the cairo dependency by switching from canvas to canvas-prebuilt

@Munter
Copy link
Member

Munter commented Oct 18, 2018

According to http://sharp.pixelplumbing.com/en/stable/install/ sharp now downloads vips automatically, so a global install might not be required

Munter added a commit that referenced this issue Oct 18, 2018
…ant. Depend on binaries through npm dependencies. Refs #627
Munter added a commit to Munter/node-histogram that referenced this issue Oct 18, 2018
Munter added a commit to Munter/node-histogram that referenced this issue Oct 18, 2018
Munter added a commit to Munter/node-histogram that referenced this issue Oct 20, 2018
Munter added a commit that referenced this issue Oct 21, 2018
…ant. Depend on binaries through npm dependencies. Refs #627
Munter added a commit that referenced this issue Dec 1, 2018
…ant. Depend on binaries through npm dependencies. Refs #627
Munter added a commit that referenced this issue Feb 11, 2019
…ant. Depend on binaries through npm dependencies. Refs #627
Munter added a commit that referenced this issue Mar 5, 2019
…ant. Depend on binaries through npm dependencies. Refs #627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants