Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Results from Olympus().run() contains results from previous runs #29

Open
wiseodd opened this issue Apr 28, 2023 · 0 comments
Open

Comments

@wiseodd
Copy link

wiseodd commented Apr 28, 2023

An issue with Olympus ’s run (and thus benchmark) method:

oly = Olympus()

for dataset in datasets:
    oly.run(dataset, ...)
    values = oly.campaign.observations.get_values().flatten()

When looking at the values of dataset[i] , it will contain values obtained from dataset[0..i-1] , so the returned value list becomes longer and longer.

I managed to circumvent this by doing the following and not using Olympus().benchmark.

for dataset in datasets:
    campaign = Campaign()
    Olympus().run(dataset, ..., campaign=campaign)
    values = campaign.observations.get_values().flatten()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant