-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
required prop for Input doesn't actually set required on the input #709
Comments
Hi. I had the same expectation, but am currently working on a form where this behavior makes sense. The form in question can be saved as a draft or published, and being able to mark its fields as @oxaudo suggested adding a separate |
@iskounen To me it just sounds like this component is semantically confusing. It's not just an input, it's a field complete with label. To me that's something else entirely. Inputs on their own should be unsurprising and accept the complete range of native props. |
Of course, I think this is a problem in terms of how to move forward 🤔 |
I see where you're coming from, and I agree. I hadn't considered your point about the label before, but it would be useful to have that be separate like it is in Bootstrap. |
Passing
<Input required />
visually denotes it as being required — I'd expect it to actually pass the prop down to the underlying input, which it doesn'tJust leaving myself this note here.
The text was updated successfully, but these errors were encountered: