Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LVM support, CRYPTROOT and current implementation. #6188

Closed
1 task
rvalle opened this issue Jan 22, 2024 · 2 comments
Closed
1 task

LVM support, CRYPTROOT and current implementation. #6188

rvalle opened this issue Jan 22, 2024 · 2 comments
Assignees
Labels
Can be closed? Ping developers on stalled issue / PR

Comments

@rvalle
Copy link
Collaborator

rvalle commented Jan 22, 2024

Which feature would you like to have?

I am in the process of adding LVM support to Armbian, unfortunately this can not be implmented from an extension.

LVM support is essentially similar to CRYPTROOT. However CRYPTROOT support is hardcoded into the partitioning image functions.

In my opinion, both CRYPTROOT and LVM, take the designated root partition, perform some custom actions, and choose a custom rootdevice.

I think it should be ideal to move CRYPTROOT to an optional extension, and then use the same framework to implement LVM support.

I think the easiest way to do his, is allowing the post_create_partitions hook to optionally pick the rootdevice.

Funding

Copy link

Jira ticket: AR-2032

@viraniac
Copy link
Collaborator

Yes, some parts are hardcoded, while others were moved to a separate extension. As you already mentioned that you are working on lvm support, probably you can move the rest to the existing extension and create an extension for LVM as well. Feel free to raise a PR with the same.

@viraniac viraniac added the Can be closed? Ping developers on stalled issue / PR label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can be closed? Ping developers on stalled issue / PR
Development

No branches or pull requests

3 participants