Triggering deletion of application as appset resource with "non-cascading" option selected leads to cascading deletion

[Brightside56]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

Triggering deletion of app as appset item with "non-cascading" option selected - leads to cascading deletion

To Reproduce

1. Create app of appsets with appset containing other apps
2. Navigate to app of appsets
3. Delete appset child application by pressing menu with three dots, "delete", "non-cascading", "ok" (or by clicking on application and pressing "delete", "non-cascading", "ok")
4. See that application resources are also deleted with application

Important: this behavior cannot be reproduced when deleting application which is not appset child application (e.g. standalone application in app of apps)

Expected behavior

Application resources aren't deleted with application, because UI offers non-cascading deletion in this case. UI should not mislead users

Screenshots

Version

2.12.3

[mikutas]

As far as I know there are at least two "delete" API, Delete and DeleteResource.

API documentation is here: your.argocd.domain/swagger-ui
cf. https://argo-cd.readthedocs.io/en/stable/developer-guide/api-docs/

Delete is exclusive for Application, and DeleteResource is used for any resources (including Application), and the meaning of "non-cascading" is different from each other.

• "non-cascading" in Delete: The resources identified by tracking label are left orphaned.
• "non-cascading" in DeleteResource: It's same as kubectl delete --cascade=orphan

I think, perhaps, when we delete a node which isn't a root, DeleteResource is called even if the node is Application.

(To project members: please correct me if I'm wrong)

[crenshaw-dev]

@mikutas that's exactly correct! I think maybe we should have a special UI for DeleteResource when deleting an Application to help the user understand the cascade options