Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Make configurations consistent #316

Open
dcfidalgo opened this issue Jun 19, 2020 · 0 comments
Open

Make configurations consistent #316

dcfidalgo opened this issue Jun 19, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@dcfidalgo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There is a slight inconsistency when creating a PipelineConfig from scratch: for example the encoder in the CharFeatures or the feedforward in the TokenClassificationConfiguration have to be specified as python dicts instead of Seq2VecEncoderConfiguration and FeedForwardConfiguration, respectively (see this tutorial).

Describe the solution you'd like
Make it more consistent by either use *Configurations objects for everything, or take advantage of AllenNLP`s from_params machinery for everything. Personally i prefer the latter, but no strong opinion here.

@dcfidalgo dcfidalgo added the enhancement New feature or request label Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant