Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Search - 2.4.6 Headings and Labels - 1 skipped heading level is present on the Search field title #9867

Closed
imogenroberts opened this issue Aug 4, 2023 · 6 comments · Fixed by #9829
Labels
Subject: Accessibility Accessibility features Type: Bug Something isn't working

Comments

@imogenroberts
Copy link
Collaborator

imogenroberts commented Aug 4, 2023

As a user reliant on a screen reader, I expect heading levels to be in a sequential order so that I can form a mental image of the structure of the page and be able to skip to content quickly.

Linked work item:
#9386

Expected Result:
Heading levels in the page should be sequential so that screen reader users are able, not only to form a mental image of the structure of the page, but also to skip to content they want without worrying that they have missed something important.

Actual Result:
The heading level here is at h4, meaning that h3 has been skipped and might cause users to believe they have missed important information on the page.

Evidence:

Image

@imogenroberts imogenroberts added Type: Bug Something isn't working Subject: Accessibility Accessibility features labels Aug 4, 2023
@apeters
Copy link
Member

apeters commented Aug 11, 2023

I think we should just remove all heading levels as it's too hard manage consistent levels

@imogenroberts
Copy link
Collaborator Author

This might actually work - as long as headings are clear and descriptive of contents they don't have to be numbered (not sure how this works from a dev standpoint). See below for full interpretation from WCAG:

image

@johnatawnclementawn
Copy link
Member

johnatawnclementawn commented Aug 14, 2023

@apeters @imogenroberts This should be resolved when #9829 is merged in.

Alexei - I see there are merge conflicts there. Those are from primarily caused by the em/rem font sizes & focus shifting PR's being merged into accessibility... so I'll just need to spend a bit of time making sure those previous changes are properly migrated into #9829. The estimate you have for this ticket is appropriate for that work

@apeters
Copy link
Member

apeters commented Sep 18, 2023

@imogenroberts this should be fixed on the latest selectwoo_integration branch

@johnatawnclementawn johnatawnclementawn linked a pull request Sep 25, 2023 that will close this issue
3 tasks
@apeters
Copy link
Member

apeters commented Oct 14, 2023

@imogenroberts this should be fixed in the latest, can you retest to confirm?

@imogenroberts
Copy link
Collaborator Author

RETEST: Skipped heading level on 'Search Facets' heading has now been fixed.

Evidence:
Advanced Search - 2 4 6  Headings and Labels FIXED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subject: Accessibility Accessibility features Type: Bug Something isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants