Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bulk-editor] Some visual indication on the preview when running #9845

Closed
njkim opened this issue Jul 28, 2023 · 1 comment · Fixed by #9846
Closed

[bulk-editor] Some visual indication on the preview when running #9845

njkim opened this issue Jul 28, 2023 · 1 comment · Fixed by #9846
Assignees
@njkim

Comments

@njkim
Copy link
Collaborator

njkim commented Jul 28, 2023

The preview can take a couple of seconds and sometimes much longer.
So, it would be great if there is some visual indication that it is running and possibly disable the button.
@njkim njkim self-assigned this Jul 28, 2023
njkim added a commit that referenced this issue Jul 28, 2023
@njkim
Add spinner while getting preview, #9845
d5ad5a2
njkim added a commit that referenced this issue Jul 28, 2023
@njkim
Disable the button, #9845
5233fce
njkim added a commit that referenced this issue Jul 28, 2023
@njkim
Initialize the array when restart, #9845
558a382
@njkim njkim mentioned this issue Jul 28, 2023
Merged
6 tasks
apeters added a commit that referenced this issue Jul 28, 2023
@apeters
clear results when previewing, re #9845
9dba385
@njkim njkim linked a pull request Jul 28, 2023 that will close this issue
spinner on preview button, #9845 #9846
Merged
6 tasks
apeters added a commit that referenced this issue Jul 28, 2023
@apeters
nit #9845
f7ffb0c
apeters added a commit that referenced this issue Jul 28, 2023
@apeters
Merge pull request #9846 from archesproject/9845_spinner_on_preview_b…
2ec3ef4 
…utton

spinner on preview button, #9845
@apeters
Copy link
Member

apeters commented Sep 19, 2023

fixed by #9846

@apeters apeters closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njkim njkim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spinner on preview button, #9845 archesproject/arches
2 participants
@apeters @njkim