Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PrimeVue 4 and use new theming API #10838

Closed
jacobtylerwalls opened this issue Apr 26, 2024 · 2 comments
Closed

Upgrade to PrimeVue 4 and use new theming API #10838

jacobtylerwalls opened this issue Apr 26, 2024 · 2 comments
Assignees

Comments

@jacobtylerwalls
Copy link
Member

Upgrade to PrimeVue 4 to take advantage of the more modern styling API. See comment.

From v4 styled mode docs:

Best Practices
Use primitive tokens when defining the core color palette and semantic tokens to specify the common design elements such as focus ring, primary colors and surfaces. Components tokens should only be used when customizing a specific component. By defining your own design tokens as a custom preset, you'll be able to define your own style without touching CSS. Overriding the PrimeVue components using style classes is not a best practice and should be the last resort, design tokens are the suggested approach.

@jacobtylerwalls
Copy link
Member Author

May involve changes to createVueApplication() to take theme inputs.

chrabyrd added a commit that referenced this issue May 29, 2024
chrabyrd added a commit that referenced this issue May 30, 2024
chrabyrd added a commit that referenced this issue May 30, 2024
@chrabyrd
Copy link
Contributor

resolved in #10990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants