Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build and show concept tree pertaining to requested scheme #111

Open
jacobtylerwalls opened this issue Oct 31, 2024 · 1 comment
Open

Comments

@jacobtylerwalls
Copy link
Member

When visiting the route for a scheme, we build the concept tree for every scheme, show them, and just highlight the requested one.

We should only build(*) the concept tree for the requested scheme and just show that one scheme's concepts.

(*) Given how indirectly the concept data is stored, it might be fine to just continue building all schemes on the first request, and just make sure to only serialize out the requested one -- OR we could change how the concept builder queries tiles to filter down on the part_of_scheme tile, and then cache those concept trees individually, but performance issues can be surprising, so we might want to measure both approaches in case the part_of_scheme lookup is costly.

@jacobtylerwalls
Copy link
Member Author

jacobtylerwalls commented Nov 4, 2024

@chrabyrd points out we should revisit the drawer/splitter decision as part of this design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant