Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Several workflows assume text entries are made in the active language #1525

Open
jacobtylerwalls opened this issue Jan 4, 2024 · 1 comment

Comments

@jacobtylerwalls
Copy link
Member

Sample/Analysis location steps

If a user picks a language in the rich text widget language switcher, it may not be the same as the active language, and so the user's choice will be discarded:

sampleMotivation: ko.unwrap(self.motivationForSamplingWidgetValue()?.[arches.activeLanguage]?.value) || ko.unwrap(self.motivationForSamplingWidgetValue),
sampleDescription: ko.unwrap(self.sampleDescriptionWidgetValue()?.[arches.activeLanguage]?.value) || ko.unwrap(self.sampleDescriptionWidgetValue),

(others in this file, too)

We should decide whether to support this use case or disable the language switcher somehow.

@jacobtylerwalls jacobtylerwalls added the question Further information is requested label Jan 4, 2024
@jacobtylerwalls
Copy link
Member Author

jacobtylerwalls commented Jan 4, 2024

Same in upload-dataset:

part.displayname = part.data[physicalThingPartNameNodeId][arches.activeLanguage]['value'];

@jacobtylerwalls jacobtylerwalls changed the title [i18n] Sample/Analysis workflows assume rich text entries are made in the active language [i18n] Sample/Analysis workflows assume text entries are made in the active language Jan 4, 2024
@jacobtylerwalls jacobtylerwalls changed the title [i18n] Sample/Analysis workflows assume text entries are made in the active language [i18n] Several workflows assume text entries are made in the active language Jan 4, 2024
@jacobtylerwalls jacobtylerwalls removed the question Further information is requested label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant