Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable travis #23

Open
dlaz opened this issue Nov 10, 2015 · 2 comments
Open

Enable travis #23

dlaz opened this issue Nov 10, 2015 · 2 comments

Comments

@dlaz
Copy link
Contributor

dlaz commented Nov 10, 2015

Could someone who has the appropriate privileges enable travis? I created a .travis.yml, but lack the privileges to enable it.

@130s
Copy link

130s commented Aug 5, 2018

+1

Downstream repo that uses packages from this repo faced a build issue (Nishida-Lab/motoman_project#117, in Japanese), which could have been avoided if Travis was enabled (and resolved potential build issue).

@MoriKen254
Copy link

I personally modified this package so as to make it pass industrial_ci 's build and test processes. You can see the repository on this link.

You'll see the travis CI status is finely built.

image

Summary Figure

The summary is as bellow.

1

2

Points

  • I separated artoolkit library from ar_tools to create devian pkg cuz I believe it's supposed to be a 3rd party lib such like OpenCV, PCL and so on, which enables other catkin pkgs to link ARToolKit's libs.
  • That's because the conventional kinda half catkinized artoolkit pkg less compatible in terms of Installation on industrial_ci space.
  • More concretely, by installing the ARToolKit pkg as a 3rd party lib, ar_pose got to refers to the general library directories such as /usr/local/lib and /usr/local/include.
  • Consequently, not only ar_tools but also other pkg being related to the ARToolKit come to be independent from conventional artoolkit.

Request

I know this modification would give kinda huge impact considering pkgs previously using the conventional ar_tools.

However, this could also compensate to next pkgs willing to use ar_tools.

If you would somewhat agree with my idea, please let me know. I'm more than welcome to refine the current configuration to the extent you expect.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants