Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Rubocop Exceptions #23

Open
egreer opened this issue Oct 15, 2018 · 0 comments
Open

Cleanup Rubocop Exceptions #23

egreer opened this issue Oct 15, 2018 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.0.0

Comments

@egreer
Copy link
Contributor

egreer commented Oct 15, 2018

As part of the test cleanup we added rubocop and created exceptions in https://github.com/apsislabs/phi_attrs/blob/master/.rubocop.yml to not impact existing behavior.

In the PR for this each of the # TODO: RUBOCOP should be an individual commit that removes the exception and fixes the offending file so that we can do a step by step comparison.
@egreer egreer added this to the 1.0.0 milestone Oct 15, 2018
@egreer egreer added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@egreer